test(linter/tsgolint): fix type errors in tsgolint fixtures#15915
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type errors in tsgolint test fixtures by updating the TypeScript configuration and converting script files to ES modules. The changes result in more accurate type checking and reduce false positive linter errors from 57 to 49.
- Updated TypeScript compiler options to use modern ES2024 target with DOM library support
- Added
export {}statements to convert script files into ES modules, preventing global scope pollution - Updated test snapshots to reflect the corrected linter output
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware@oxlint.snap | Updated snapshot reflecting reduced error count (49 vs 57) and corrected error messages after type fixes |
| apps/oxlint/fixtures/tsgolint/tsconfig.json | Updated compiler options to es2024 target, added DOM lib, and changed module to es2022 for better type inference |
| apps/oxlint/fixtures/tsgolint/*.ts (20 files) | Added export {} statements to convert scripts to ES modules, preventing TypeScript global scope issues |
| apps/oxlint/fixtures/tsgolint_disable_directives/unused.ts | Added export {} to convert to ES module for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
6ee9dba to
a299a38
Compare

No description provided.