Skip to content

Comments

test(linter/tsgolint): fix type errors in tsgolint fixtures#15915

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-20-test_linter_tsgolint_fix_type_errors_in_tsgolint_fixtures
Nov 20, 2025
Merged

test(linter/tsgolint): fix type errors in tsgolint fixtures#15915
graphite-app[bot] merged 1 commit intomainfrom
c/11-20-test_linter_tsgolint_fix_type_errors_in_tsgolint_fixtures

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 20, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review November 20, 2025 15:25
Copilot AI review requested due to automatic review settings November 20, 2025 15:25
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 20, 2025
Copy link
Contributor Author

camc314 commented Nov 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes type errors in tsgolint test fixtures by updating the TypeScript configuration and converting script files to ES modules. The changes result in more accurate type checking and reduce false positive linter errors from 57 to 49.

  • Updated TypeScript compiler options to use modern ES2024 target with DOM library support
  • Added export {} statements to convert script files into ES modules, preventing global scope pollution
  • Updated test snapshots to reflect the corrected linter output

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 11 comments.

File Description
apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware@oxlint.snap Updated snapshot reflecting reduced error count (49 vs 57) and corrected error messages after type fixes
apps/oxlint/fixtures/tsgolint/tsconfig.json Updated compiler options to es2024 target, added DOM lib, and changed module to es2022 for better type inference
apps/oxlint/fixtures/tsgolint/*.ts (20 files) Added export {} statements to convert scripts to ES modules, preventing TypeScript global scope issues
apps/oxlint/fixtures/tsgolint_disable_directives/unused.ts Added export {} to convert to ES module for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/11-20-test_linter_tsgolint_fix_type_errors_in_tsgolint_fixtures branch from 6ee9dba to a299a38 Compare November 20, 2025 15:47
@graphite-app graphite-app bot merged commit a299a38 into main Nov 20, 2025
18 checks passed
@graphite-app graphite-app bot deleted the c/11-20-test_linter_tsgolint_fix_type_errors_in_tsgolint_fixtures branch November 20, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant