Skip to content

fix(linter): recognize NewExpression as value context in no-unused-private-class-members #15843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 18, 2025
Merged

fix(linter): recognize NewExpression as value context in no-unused-private-class-members #15843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ fn is_value_context(parent: &AstNode, child: &AstNode, semantic: &Semantic<'_>)
match parent.kind() {
AstKind::ReturnStatement(_)
| AstKind::CallExpression(_)
| AstKind::NewExpression(_)
| AstKind::BinaryExpression(_)
| AstKind::VariableDeclarator(_)
| AstKind::PropertyDefinition(_)
Expand Down Expand Up @@ -493,6 +494,7 @@ fn test() {
r"class ExampleFoo { #foo = 0; foo(foo) { foo = foo ?? this.#foo; return foo; } }",
// Issue #15548: Private member used in update expression on RHS of assignment
r"class ExampleBar { #bar = 0; bar(bar) { bar = ++this.#bar; return bar; } }",
r"class Test { #url: string; constructor(url: string) { this.#url = url; } open() { return new WebSocket(this.#url); } }",
];

let fail = vec![
Expand Down
Loading