Skip to content

Comments

test(linter/prefer-namespace-keyword): remove test case with invalid syntax#15833

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-18-test_linter_prefer-namespace-keyword_remove_test_case_with_invalid_syntax
Nov 18, 2025
Merged

test(linter/prefer-namespace-keyword): remove test case with invalid syntax#15833
graphite-app[bot] merged 1 commit intomainfrom
c/11-18-test_linter_prefer-namespace-keyword_remove_test_case_with_invalid_syntax

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 18, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review November 18, 2025 10:00
Copilot AI review requested due to automatic review settings November 18, 2025 10:00
@github-actions github-actions bot added the A-linter Area - Linter label Nov 18, 2025
Copy link
Contributor Author

camc314 commented Nov 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an invalid test case from the prefer-namespace-keyword linter rule that was causing a parse error rather than testing the intended rule behavior.

  • Removed test case with invalid syntax "module foo.'a'" that produced a parse error
  • Removed corresponding snapshot entry showing "Unexpected token" error

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/typescript/prefer_namespace_keyword.rs Removed invalid test case "module foo.'a'" from the fail test cases
crates/oxc_linter/src/snapshots/typescript_prefer_namespace_keyword.snap Removed corresponding snapshot output for the invalid test case showing parse error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/11-18-test_linter_prefer-namespace-keyword_remove_test_case_with_invalid_syntax branch from 1ea734c to f7ef032 Compare November 18, 2025 10:05
@graphite-app graphite-app bot merged commit f7ef032 into main Nov 18, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/11-18-test_linter_prefer-namespace-keyword_remove_test_case_with_invalid_syntax branch November 18, 2025 10:09
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #15833 will not alter performance

Comparing c/11-18-test_linter_prefer-namespace-keyword_remove_test_case_with_invalid_syntax (f7ef032) with main (646d020)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (f7ef032) during the generation of this report, so 646d020 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant