Skip to content

refactor(linter/plugins): improve rule validation error messages #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 17, 2025
Merged

refactor(linter/plugins): improve rule validation error messages #15812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions apps/oxlint/src-js/plugins/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,22 +149,24 @@ async function loadPluginImpl(path: string, packageName: string | null): Promise
rule = rules[ruleName];

// Validate `rule.meta` and convert to vars with standardized shape
let isFixable = false;
let messages: Record<string, string> | null = null;
let ruleMeta = rule.meta;
let isFixable = false,
messages: Record<string, string> | null = null;
const ruleMeta = rule.meta;
if (ruleMeta != null) {
if (typeof ruleMeta !== 'object') throw new TypeError('Invalid `meta`');
if (typeof ruleMeta !== 'object') throw new TypeError('Invalid `rule.meta`');

const { fixable } = ruleMeta;
if (fixable != null) {
if (fixable !== 'code' && fixable !== 'whitespace') throw new TypeError('Invalid `meta.fixable`');
if (fixable !== 'code' && fixable !== 'whitespace') throw new TypeError('Invalid `rule.meta.fixable`');
isFixable = true;
}

// Extract messages for messageId support
const inputMessages = ruleMeta.messages;
if (inputMessages != null) {
if (typeof inputMessages !== 'object') throw new TypeError('`meta.messages` must be an object if provided');
if (typeof inputMessages !== 'object') {
throw new TypeError('`rule.meta.messages` must be an object if provided');
}
messages = inputMessages;
}
}
Expand Down
Loading