Skip to content

test(linter/plugins): simplify test case #15808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 17, 2025
+13 −36
Merged

test(linter/plugins): simplify test case #15808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/oxlint/test/fixtures/sourceCode_scope_methods/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
3 |
`----

x scope-plugin(scope): getScope(topLevelFunction): type: function
x scope-plugin(scope): getScope(topLevelFunction):
| type: function
| isStrict: true
| vars: [arguments, param, localConstant]
| variables: [arguments, param, localConstant]
| through: [topLevelConstant, Math]
| upper: module
|
| upper type: module
,-[files/index.js:4:1]
3 |
4 | ,-> function topLevelFunction(param) {
Expand Down
41 changes: 9 additions & 32 deletions apps/oxlint/test/fixtures/sourceCode_scope_methods/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,4 @@
import assert from 'node:assert';

import type { ESTree, Node, Plugin, Rule, Scope, Variable } from '../../../dist/index.js';

type Program = ESTree.Program;

type Identifier =
| ESTree.IdentifierName
| ESTree.IdentifierReference
| ESTree.BindingIdentifier
| ESTree.LabelIdentifier;

const SPAN: Node = {
start: 0,
end: 0,
range: [0, 0],
loc: {
start: { line: 0, column: 0 },
end: { line: 0, column: 0 },
},
};
import type { Plugin, Rule } from '../../../dist/index.js';

const rule: Rule = {
create(context) {
Expand All @@ -33,24 +13,21 @@ const rule: Rule = {
});
},
Identifier(node) {
const { name } = node;
const isGlobal = sourceCode.isGlobalReference(node);
context.report({
message: `isGlobalReference(${name}): ${isGlobal}`,
message: `isGlobalReference(${node.name}): ${sourceCode.isGlobalReference(node)}`,
node,
});
},
FunctionDeclaration(node) {
const scope = sourceCode.getScope(node);
let text = '';
text += `type: ${scope.type}\n`;
text += `isStrict: ${scope.isStrict}\n`;
text += `vars: [${scope.variables.map((v) => v.name).join(', ')}]\n`;
text += `through: [${scope.through.map((r) => (r.identifier as any).name).join(', ')}]\n`;
if (scope.upper) text += `upper: ${scope.upper.type}\n`;

context.report({
message: `getScope(${node.id.name}): ${text}`,
message:
`getScope(${node.id.name}):\n` +
`type: ${scope.type}\n` +
`isStrict: ${scope.isStrict}\n` +
`variables: [${scope.variables.map((v) => v.name).join(', ')}]\n` +
`through: [${scope.through.map((r) => r.identifier.name).join(', ')}]\n` +
`upper type: ${scope.upper?.type}`,
node,
});
},
Expand Down
Loading