Skip to content

fix(formatter): CRLF issue in the member chain #15764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 17, 2025
+4 −11
Merged

fix(formatter): CRLF issue in the member chain #15764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions crates/oxc_formatter/src/utils/member_chain/groups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,17 +218,10 @@ impl<'a, 'b> MemberChainGroup<'a, 'b> {

// Count the number of continuous new lines
let mut new_lines_count = 0;
for &b in source.bytes_range(start, end) {
if matches!(b, b'\n' | b'\r') {
new_lines_count += 1;
// If there are more than 1 continuous new lines, return true
if new_lines_count > 1 {
return true;
}
} else if !b.is_ascii_whitespace() {
// Reset the counter if there is a non-new-line character,
// because the new lines are not continuous
new_lines_count = 0;
for (idx, &b) in source.bytes_range(start, end).iter().enumerate() {
#[expect(clippy::cast_possible_truncation)]
if matches!(b, b'\n' | b'\r') && source.lines_after(start + idx as u32) > 1 {
return true;
}
}

Expand Down
Loading