refactor(traverse): remove dead code#15685
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead code by eliminating the unused CommentNodeId import that was introduced in #11214 but never utilized. The change also removes the #![allow(unused_imports)] attribute that was likely added to suppress warnings about the unused import.
- Removes unused
CommentNodeIdimport fromoxc_syntax - Removes the
#![allow(unused_imports)]attribute that is no longer necessary - Updates both the generated file and the code generator script for consistency
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_traverse/src/generated/ancestor.rs | Removed unused import and allow attribute from generated file |
| crates/oxc_traverse/scripts/lib/ancestor.mjs | Updated code generator to stop generating the unused import and allow attribute |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #15685 will not alter performanceComparing Summary
Footnotes
|
Pure refactor. Remove dead import of `CommentNodeId`. It was introduced in #11214, but we didn't end up using it.
83ab61c to
8c5b958
Compare

Pure refactor. Remove dead import of
CommentNodeId. It was introduced in #11214, but we didn't end up using it.