Skip to content

refactor(traverse): remove dead code#15685

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-14-refactor_traverse_remove_dead_code
Nov 14, 2025
Merged

refactor(traverse): remove dead code#15685
graphite-app[bot] merged 1 commit intomainfrom
11-14-refactor_traverse_remove_dead_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 14, 2025

Pure refactor. Remove dead import of CommentNodeId. It was introduced in #11214, but we didn't end up using it.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 14, 2025 01:05
Copilot AI review requested due to automatic review settings November 14, 2025 01:05
@overlookmotel overlookmotel self-assigned this Nov 14, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 14, 2025
Copy link
Member Author

overlookmotel commented Nov 14, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code by eliminating the unused CommentNodeId import that was introduced in #11214 but never utilized. The change also removes the #![allow(unused_imports)] attribute that was likely added to suppress warnings about the unused import.

  • Removes unused CommentNodeId import from oxc_syntax
  • Removes the #![allow(unused_imports)] attribute that is no longer necessary
  • Updates both the generated file and the code generator script for consistency

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_traverse/src/generated/ancestor.rs Removed unused import and allow attribute from generated file
crates/oxc_traverse/scripts/lib/ancestor.mjs Updated code generator to stop generating the unused import and allow attribute

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #15685 will not alter performance

Comparing 11-14-refactor_traverse_remove_dead_code (83ab61c) with main (f5d9abb)1

Summary

✅ 33 untouched
⏩ 4 skipped2

Footnotes

  1. No successful run was found on main (78b6708) during the generation of this report, so f5d9abb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Pure refactor. Remove dead import of `CommentNodeId`. It was introduced in #11214, but we didn't end up using it.
@graphite-app graphite-app bot force-pushed the 11-14-refactor_traverse_remove_dead_code branch from 83ab61c to 8c5b958 Compare November 14, 2025 01:10
@graphite-app graphite-app bot merged commit 8c5b958 into main Nov 14, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-14-refactor_traverse_remove_dead_code branch November 14, 2025 01:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants