Skip to content

Comments

refactor(linter): remove feature flag language_server#15646

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-12-refactor_linter_remove_feature_flag_language_server_
Nov 12, 2025
Merged

refactor(linter): remove feature flag language_server#15646
graphite-app[bot] merged 1 commit intomainfrom
11-12-refactor_linter_remove_feature_flag_language_server_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 12, 2025

With #15611 the language server is included in all package including oxc_linter.
Removing the feature flag because it is obsolete now.

graphic showing very small performance regression

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 12, 2025
Copy link
Member Author

Sysix commented Nov 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 12, 2025

CodSpeed Performance Report

Merging #15646 will not alter performance

Comparing 11-12-refactor_linter_remove_feature_flag_language_server_ (8dc92a2) with main (d5a9e94)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (a210b12) during the generation of this report, so d5a9e94 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix marked this pull request as ready for review November 12, 2025 20:03
@Sysix Sysix requested a review from camc314 as a code owner November 12, 2025 20:03
Copilot AI review requested due to automatic review settings November 12, 2025 20:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete language_server feature flag from the oxc_linter crate, as the language server functionality is now included in all packages by default. The changes simplify the codebase by eliminating conditional compilation directives and directly enabling the rope feature in dependencies.

  • Removed all #[cfg(feature = "language_server")] conditional compilation attributes
  • Consolidated imports that were previously feature-gated
  • Updated Cargo.toml to unconditionally enable the rope feature in oxc_data_structures

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/oxc_linter/Cargo.toml Removed the language_server feature definition and made rope dependency unconditional
crates/oxc_language_server/Cargo.toml Removed the language_server feature flag from oxc_linter dependency
crates/oxc_linter/src/tsgolint.rs Removed feature gates from imports and methods, consolidated imports
crates/oxc_linter/src/service/runtime.rs Removed feature gate from run_source method and simplified imports
crates/oxc_linter/src/service/mod.rs Removed feature gate from run_source method
crates/oxc_linter/src/lint_runner.rs Consolidated imports and removed feature gates from run_source method
crates/oxc_linter/src/fixer/mod.rs Removed feature gates from section_offset field and its initialization
crates/oxc_linter/src/context/mod.rs Removed conditional compilation blocks in diagnostic methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix force-pushed the 11-12-refactor_linter_remove_feature_flag_language_server_ branch from f918f16 to 8dc92a2 Compare November 12, 2025 20:10
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
Copy link
Contributor

camc314 commented Nov 12, 2025

Merge activity

With #15611 the language server is included in all package including `oxc_linter`.
Removing the feature flag because it is obsolete now.

<img width="1180" height="327" alt="graphic showing very small performance regression" src="https://github.com/user-attachments/assets/129bd94f-0392-41b0-a23f-ec70d174279e" />
@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_remove_feature_flag_language_server_ branch from 8dc92a2 to c806074 Compare November 12, 2025 21:27
@graphite-app graphite-app bot merged commit c806074 into main Nov 12, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-12-refactor_linter_remove_feature_flag_language_server_ branch November 12, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants