refactor(linter): remove feature flag language_server#15646
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15646 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete language_server feature flag from the oxc_linter crate, as the language server functionality is now included in all packages by default. The changes simplify the codebase by eliminating conditional compilation directives and directly enabling the rope feature in dependencies.
- Removed all
#[cfg(feature = "language_server")]conditional compilation attributes - Consolidated imports that were previously feature-gated
- Updated
Cargo.tomlto unconditionally enable theropefeature inoxc_data_structures
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_linter/Cargo.toml | Removed the language_server feature definition and made rope dependency unconditional |
| crates/oxc_language_server/Cargo.toml | Removed the language_server feature flag from oxc_linter dependency |
| crates/oxc_linter/src/tsgolint.rs | Removed feature gates from imports and methods, consolidated imports |
| crates/oxc_linter/src/service/runtime.rs | Removed feature gate from run_source method and simplified imports |
| crates/oxc_linter/src/service/mod.rs | Removed feature gate from run_source method |
| crates/oxc_linter/src/lint_runner.rs | Consolidated imports and removed feature gates from run_source method |
| crates/oxc_linter/src/fixer/mod.rs | Removed feature gates from section_offset field and its initialization |
| crates/oxc_linter/src/context/mod.rs | Removed conditional compilation blocks in diagnostic methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f918f16 to
8dc92a2
Compare
Merge activity
|
With #15611 the language server is included in all package including `oxc_linter`. Removing the feature flag because it is obsolete now. <img width="1180" height="327" alt="graphic showing very small performance regression" src="https://github.com/user-attachments/assets/129bd94f-0392-41b0-a23f-ec70d174279e" />
8dc92a2 to
c806074
Compare

With #15611 the language server is included in all package including
oxc_linter.Removing the feature flag because it is obsolete now.