Skip to content

Comments

feat(oxc_minify_napi): expose TreeShakeOptions#15618

Closed
sapphi-red wants to merge 1 commit intomainfrom
11-12-feat_oxc_minify_napi_expose_treeshakeoptions_
Closed

feat(oxc_minify_napi): expose TreeShakeOptions#15618
sapphi-red wants to merge 1 commit intomainfrom
11-12-feat_oxc_minify_napi_expose_treeshakeoptions_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 12, 2025 •
edited
Loading

Similar to #13288. I wonder if it's possible to ensure the types are exposed.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 12, 2025
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Nov 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested a review from Boshen November 12, 2025 04:29
@sapphi-red sapphi-red self-assigned this Nov 12, 2025
@sapphi-red sapphi-red marked this pull request as ready for review November 12, 2025 04:29
Copilot AI review requested due to automatic review settings November 12, 2025 04:29
@sapphi-red sapphi-red assigned Boshen and unassigned sapphi-red Nov 12, 2025
Copilot AI reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the TreeShakeOptions type from the oxc_minify_napi library, making it available for consumers to import and use directly. The TreeShakeOptions interface already exists in the TypeScript definitions but wasn't previously exported from the Rust library's public API.

Key Changes:

  • Added TreeShakeOptions to the public re-exports in the NAPI minify library

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Boshen
Copy link
Member

Boshen commented Nov 12, 2025

I'll change all options to export * to make these future proof.

@Boshen Boshen closed this in f5ce55a Nov 13, 2025
Boshen added a commit that referenced this pull request Nov 13, 2025
@Boshen @claude
feat(napi): export all options using wildcard exports
6134c64 
Closes #15618

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Boshen Boshen mentioned this pull request Nov 13, 2025
Closed
@sapphi-red sapphi-red deleted the 11-12-feat_oxc_minify_napi_expose_treeshakeoptions_ branch November 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen