Skip to content

Comments

refactor(linter/plugins): add comments on Context#extend#15604

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-11-refactor_linter_plugins_add_comments_on_context_extend_
Nov 11, 2025
Merged

refactor(linter/plugins): add comments on Context#extend#15604
graphite-app[bot] merged 1 commit intomainfrom
11-11-refactor_linter_plugins_add_comments_on_context_extend_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025

Add comments on extend methods explaining why they're OK to use in createContext.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 11, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 17:50
Copilot AI review requested due to automatic review settings November 11, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explanatory comments to the extend method in both apps/oxlint/src-js/plugins/context.ts and apps/oxlint/src-js/index.ts to clarify why this method is safe to use within the createOnce API. The comments explain that extend doesn't involve file-specific state, making it appropriate for use during the createOnce phase.

  • Adds inline documentation explaining the safety of the extend method in createOnce context
  • Maintains consistency with similar explanatory comments for other safe-to-use methods like cwd

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/context.ts Adds comment explaining that extend is safe to call in createOnce because it doesn't involve file-specific state
apps/oxlint/src-js/index.ts Adds the same explanatory comment for the extend method in the ESLint-compatible implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

Merge activity

@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins and removed A-linter Area - Linter labels Nov 11, 2025
Add comments on `extend` methods explaining why they're OK to use in `createContext`.
@graphite-app graphite-app bot force-pushed the 11-11-refactor_linter_plugins_add_comments_on_context_extend_ branch from 022e6ad to 2de35be Compare November 11, 2025 17:55
@github-actions github-actions bot added the A-linter Area - Linter label Nov 11, 2025
@graphite-app graphite-app bot merged commit 2de35be into main Nov 11, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-11-refactor_linter_plugins_add_comments_on_context_extend_ branch November 11, 2025 18:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant