Skip to content

Comments

ci(ast_tools): run "AST Changes" CI task when CI workflow file changes#15591

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes
Nov 11, 2025
Merged

ci(ast_tools): run "AST Changes" CI task when CI workflow file changes#15591
graphite-app[bot] merged 1 commit intomainfrom
11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025

Add path to CI workflow file to the watch list for "AST Changes" CI task, so the task runs if the workflow is altered.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Nov 11, 2025
Copy link
Member Author

overlookmotel commented Nov 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 12:35
Copilot AI review requested due to automatic review settings November 11, 2025 12:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the CI workflow file (.github/workflows/ci.yml) to the watch list for the "AST Changes" CI task. This ensures the task runs whenever the workflow file itself is modified, maintaining consistency with how other CI tasks explicitly include the workflow file in their path filters.

Key Changes:

  • Added .github/workflows/ci.yml to the list of paths that trigger the "AST Changes" CI task
  • Refactored the code to extract hardcoded paths into an additional_paths array with inline comments for better clarity

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
tasks/ast_tools/src/output/yaml.rs Added CI workflow path to the additional paths array and improved code documentation with inline comments
.github/generated/ast_changes_watch_list.yml Auto-generated file now includes the CI workflow path in the sorted watch list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
#15591)

Add path to CI workflow file to the watch list for "AST Changes" CI task, so the task runs if the workflow is altered.
@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes branch from 37139a3 to 448cc05 Compare November 11, 2025 12:45
#15591)

Add path to CI workflow file to the watch list for "AST Changes" CI task, so the task runs if the workflow is altered.
@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes branch from 448cc05 to ec66eb4 Compare November 11, 2025 12:47
@graphite-app graphite-app bot merged commit ec66eb4 into main Nov 11, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes branch November 11, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant