Skip to content

ci(release_apps): fix zizmor error#15589

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-11-ci_release_apps_fix_zizmor_error
Nov 11, 2025
Merged

ci(release_apps): fix zizmor error#15589
graphite-app[bot] merged 1 commit intomainfrom
11-11-ci_release_apps_fix_zizmor_error

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 11, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 11, 2025 10:54
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Member Author

Boshen commented Nov 11, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses security warnings from zizmor by refactoring GitHub Actions workflow expressions to use environment variables instead of inline interpolation, and adding a suppression comment for a false positive.

  • Replaced inline ${{ }} expressions in shell scripts with environment variables to prevent potential injection attacks
  • Added zizmor ignore comment for a false positive warning about trusted publishing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release_apps.yml Converted inline GitHub expressions to environment variables in the changelog generation step
.github/workflows/prepare_release_crates.yml Added zizmor ignore comment for dry-run command that doesn't require trusted publishing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the 11-11-ci_release_apps_fix_zizmor_error branch from 9215175 to 6a982f6 Compare November 11, 2025 11:03
@graphite-app graphite-app bot merged commit 6a982f6 into main Nov 11, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-11-ci_release_apps_fix_zizmor_error branch November 11, 2025 11:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants