feat(minifier): rotate binary expressions to remove parentheses by sapphi-red · Pull Request #15473 · oxc-project/oxc

sapphi-red · 2025-11-08T11:40:32Z

Compress a | (b | c) to a | b | c and a * (b % c) to b % c * a.

sapphi-red · 2025-11-08T11:40:46Z

feat(minifier): rotate binary expressions to remove parentheses #15473 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-11-08T11:45:44Z

CodSpeed Performance Report

Merging #15473 will not alter performance

_{Comparing 11-08-feat_minifier_rotate_binary_expressions_to_remove_parentheses (d993ecd) with main (eeed5de)}

Summary

✅ 33 untouched
⏩ 4 skipped¹

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR implements binary expression rotation optimizations in the minifier to reduce code size by eliminating unnecessary parentheses and reordering expressions. The implementation handles two types of rotation: associative rotation for bitwise operators (e.g., a | (b | c) → (a | b) | c) and commutative rotation for multiplication with same-precedence operators (e.g., a * (b % c) → b % c * a).

Key Changes:

Added substitute_rotate_binary_expression function to handle binary expression rotation
Integrated the new optimization into the minifier's expression processing pipeline
Added comprehensive test coverage for both associative and commutative rotation cases

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs	Implements the binary expression rotation logic with associative rotation for bitwise operators and commutative rotation for multiplication
crates/oxc_minifier/src/peephole/mod.rs	Integrates the new rotation optimization into the binary expression processing pipeline
tasks/track_memory_allocations/allocs_minifier.snap	Updates memory allocation benchmarks reflecting the impact of the new optimization
tasks/minsize/minsize.snap	Updates minification size benchmarks with minor improvements from the optimization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs

Boshen · 2025-11-11T16:12:57Z

Merge activity

Nov 11, 4:12 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 11, 4:12 PM UTC: Boshen added this pull request to the Graphite merge queue.
Nov 11, 4:23 PM UTC: Merged by the Graphite merge queue.

Compress `a | (b | c)` to `a | b | c` and `a * (b % c)` to `b % c * a`.

### 💥 BREAKING CHANGES - ea51b0b napi: [**BREAKING**] Standardize function naming with sync suffixes (#15661) (Boshen) ### 🚀 Features - 77efb76 parser: Improve error message for invalid switch clauses (#15728) (sapphi-red) - 5691727 parser: Improve `import source` `from` error message (#15727) (sapphi-red) - b7404bc parser: Improve error message for missing function body (#15726) (sapphi-red) - 71c2fb0 parser: Improve error message when JSX is found while not enabled (#15725) (sapphi-red) - 56e7e44 minifier: Disable removal of unnecessary `use strict` directives for DCE (#15691) (sapphi-red) - 8a61cfd allocator, ast: Introduce `UnstableAddress` trait (#15700) (overlookmotel) - f5ce55a napi: Export all options using wildcard exports (Boshen) - 68703b9 minifier: Rotate binary expressions to remove parentheses (#15473) (sapphi-red) ### 🐛 Bug Fixes - c023ba6 semantic: Do not duplicate statements in temp `Vec` when binding `TSModuleDeclaration`s (#15724) (overlookmotel) - d60ca81 parser: Reject `import something 'source'` (#15746) (sapphi-red) - e0728fa ast: Exclude comment end position from `is_inside_comment` check (#15753) (camc314) - 9f54a36 semantic: Error on `\00` in strict mode (#15743) (sapphi-red) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) ### ⚡ Performance - 1f09d3c parser: Faster checking for invalid modifiers (#15717) (overlookmotel) - d8d4e31 ast: Use loop instead of recursion in `TSModuleDeclarationBody::as_module_block_mut` (#15713) (overlookmotel) ### 📚 Documentation - e033d50 ast: Clarify behavior of `TSModuleDeclaration::has_use_strict_directive` (#15730) (overlookmotel) - 9eda70f allocator: Improve docs for `Address` methods (#15697) (overlookmotel)

### 💥 BREAKING CHANGES - ea51b0b napi: [**BREAKING**] Standardize function naming with sync suffixes (oxc-project#15661) (Boshen) ### 🚀 Features - 77efb76 parser: Improve error message for invalid switch clauses (oxc-project#15728) (sapphi-red) - 5691727 parser: Improve `import source` `from` error message (oxc-project#15727) (sapphi-red) - b7404bc parser: Improve error message for missing function body (oxc-project#15726) (sapphi-red) - 71c2fb0 parser: Improve error message when JSX is found while not enabled (oxc-project#15725) (sapphi-red) - 56e7e44 minifier: Disable removal of unnecessary `use strict` directives for DCE (oxc-project#15691) (sapphi-red) - 8a61cfd allocator, ast: Introduce `UnstableAddress` trait (oxc-project#15700) (overlookmotel) - f5ce55a napi: Export all options using wildcard exports (Boshen) - 68703b9 minifier: Rotate binary expressions to remove parentheses (oxc-project#15473) (sapphi-red) ### 🐛 Bug Fixes - c023ba6 semantic: Do not duplicate statements in temp `Vec` when binding `TSModuleDeclaration`s (oxc-project#15724) (overlookmotel) - d60ca81 parser: Reject `import something 'source'` (oxc-project#15746) (sapphi-red) - e0728fa ast: Exclude comment end position from `is_inside_comment` check (oxc-project#15753) (camc314) - 9f54a36 semantic: Error on `\00` in strict mode (oxc-project#15743) (sapphi-red) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (oxc-project#15710) (camc314) ### ⚡ Performance - 1f09d3c parser: Faster checking for invalid modifiers (oxc-project#15717) (overlookmotel) - d8d4e31 ast: Use loop instead of recursion in `TSModuleDeclarationBody::as_module_block_mut` (oxc-project#15713) (overlookmotel) ### 📚 Documentation - e033d50 ast: Clarify behavior of `TSModuleDeclaration::has_use_strict_directive` (oxc-project#15730) (overlookmotel) - 9eda70f allocator: Improve docs for `Address` methods (oxc-project#15697) (overlookmotel)

github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 8, 2025

sapphi-red force-pushed the 11-08-feat_minifier_rotate_binary_expressions_to_remove_parentheses branch from 6c3d79a to d993ecd Compare November 8, 2025 11:50

sapphi-red requested a review from Boshen November 8, 2025 11:56

sapphi-red assigned Boshen Nov 8, 2025

sapphi-red marked this pull request as ready for review November 8, 2025 11:56

Copilot AI review requested due to automatic review settings November 8, 2025 11:56

Copilot AI reviewed Nov 8, 2025

View reviewed changes

crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs Show resolved Hide resolved

crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs Show resolved Hide resolved

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025

feat(minifier): rotate binary expressions to remove parentheses (#15473)

68703b9

Compress `a | (b | c)` to `a | b | c` and `a * (b % c)` to `b % c * a`.

graphite-app bot force-pushed the 11-08-feat_minifier_rotate_binary_expressions_to_remove_parentheses branch from d993ecd to 68703b9 Compare November 11, 2025 16:17

graphite-app bot merged commit 68703b9 into main Nov 11, 2025
20 checks passed

graphite-app bot deleted the 11-08-feat_minifier_rotate_binary_expressions_to_remove_parentheses branch November 11, 2025 16:23

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025

Boshen mentioned this pull request Nov 17, 2025

release(crates): oxc v0.98.0 #15771

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(minifier): rotate binary expressions to remove parentheses#15473

feat(minifier): rotate binary expressions to remove parentheses#15473
graphite-app[bot] merged 1 commit intomainfrom
11-08-feat_minifier_rotate_binary_expressions_to_remove_parentheses

sapphi-red commented Nov 8, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Nov 8, 2025

Uh oh!

codspeed-hq bot commented Nov 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Boshen commented Nov 11, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

sapphi-red commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Nov 8, 2025

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15473 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Boshen commented Nov 11, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Nov 8, 2025 •

edited

Loading

codspeed-hq bot commented Nov 8, 2025 •

edited

Loading

Boshen commented Nov 11, 2025 •

edited by graphite-app bot

Loading