Skip to content

fix(ast/estree): fix raw transfer deserializer for AssignmentTargetPropertyIdentifier#15304

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_
Nov 5, 2025
Merged

fix(ast/estree): fix raw transfer deserializer for AssignmentTargetPropertyIdentifier#15304
graphite-app[bot] merged 1 commit intomainfrom
10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025

  1. Tiny bug fix - make sure range arrays for key and value are independent objects, so mutating one doesn't mutate the other.
  2. Perf optimization - remove usage of ... spread, which is expensive.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast Area - AST labels Nov 5, 2025
Copy link
Member Author

overlookmotel commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #15304 will not alter performance

Comparing 10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ (2b1f9b5) with main (798216b)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on 10-22-refactor_ast_estree_shorten_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ (9a8e54d) during the generation of this report, so main (798216b) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review November 5, 2025 10:45
@overlookmotel overlookmotel self-assigned this Nov 5, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2025

Merge activity

…ropertyIdentifier` (#15304)

1. Tiny bug fix - make sure `range` arrays for `key` and `value` are independent objects, so mutating one doesn't mutate the other.
2. Perf optimization - remove usage of `...` spread, which is expensive.
@graphite-app graphite-app bot force-pushed the 10-22-refactor_ast_estree_shorten_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ branch from 9a8e54d to a7cf856 Compare November 5, 2025 11:23
@graphite-app graphite-app bot force-pushed the 10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ branch from 2b1f9b5 to 7f079ab Compare November 5, 2025 11:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Base automatically changed from 10-22-refactor_ast_estree_shorten_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ to main November 5, 2025 11:29
@graphite-app graphite-app bot merged commit 7f079ab into main Nov 5, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ branch November 5, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-cli Area - CLI A-linter Area - Linter A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments