perf(linter/plugins): faster check for cwd#15301
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the current working directory caching mechanism in the Context class. The change removes the getInternal validation check when accessing context.cwd since the current working directory is a global property that can be safely accessed even within createOnce.
- Renamed
cachedCwdtocwdfor clarity - Removed the
getInternal()guard from thecwdgetter to allow access increateOnce - Replaced nullish coalescing with an explicit null check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
074d0f0 to
ee9f2f4
Compare

Follow-on after #14814. Small perf optimization.
cwdis eithernullor a string, so use cheaper=== nullcheck instead of??(which is equivalent tocwd === null || cwd === undefined).Also rename the var, just for brevity.