feat(parser): improve trailing comma error messages#15267
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 4, 2025
Merged
feat(parser): improve trailing comma error messages#15267graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 4, 2025
CodSpeed Performance ReportMerging #15267 will not alter performanceComparing Summary
|
sapphi-red
force-pushed
the
11-03-feat_parser_improve_trailing_comma_error_messages
branch
from
dedfa97 to
e0dba36
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error messages for trailing commas in TypeScript and JavaScript parsers by introducing a new generic unexpected_trailing_comma function to provide more descriptive and consistent error messages.
- Introduces a new
unexpected_trailing_commadiagnostic function to standardize trailing comma error reporting - Updates error messages for index signatures and parenthesized expressions to be more descriptive
- Refactors
rest_element_trailing_commato use the new generic function
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_parser/src/diagnostics.rs | Adds new unexpected_trailing_comma function and refactors rest_element_trailing_comma to use it |
| crates/oxc_parser/src/ts/types.rs | Updates index signature trailing comma error to use new diagnostic function |
| crates/oxc_parser/src/js/expression.rs | Updates parenthesized expression trailing comma error to use new diagnostic function |
| tasks/coverage/snapshots/parser_typescript.snap | Updates snapshot tests to reflect improved error messages |
| tasks/coverage/snapshots/parser_babel.snap | Updates snapshot tests to reflect improved error messages |
| tasks/track_memory_allocations/allocs_parser.snap | Updates memory allocation statistics for cal.com.tsx |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Improved error message for trailing comma related errors (e.g. `('foo',)`, ` type A = { [key: string,]: string; }`).
graphite-app
bot
force-pushed
the
11-03-feat_parser_improve_trailing_comma_error_messages
branch
from
e0dba36 to
5f203c6
Compare
graphite-app
bot
deleted the
11-03-feat_parser_improve_trailing_comma_error_messages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved error message for trailing comma related errors (e.g.
('foo',),type A = { [key: string,]: string; }).