Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Nov 1, 2025

I believe some of the rules under Next.js should only run when the source type variant is jsx. If that’s correct, I’ll gradually refine those rules across the next few PRs.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 1, 2025
Copy link
Member Author

shulaoda commented Nov 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 1, 2025
@shulaoda shulaoda marked this pull request as ready for review November 1, 2025 03:36
@shulaoda shulaoda requested a review from camc314 as a code owner November 1, 2025 03:36
Copilot AI review requested due to automatic review settings November 1, 2025 03:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a performance optimization to the no_unwanted_polyfillio Next.js linter rule by implementing a should_run method that filters out non-JSX files before running the rule.

  • Implements should_run to skip non-JSX files
  • Uses ctx.source_type().is_jsx() check for early exit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shulaoda shulaoda force-pushed the 11-01-perf_linter_no-unwanted-polyfillio_should_run_when_source_type_is_jsx branch from bad5376 to af261a0 Compare November 1, 2025 03:38
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 1, 2025

CodSpeed Performance Report

Merging #15204 will not alter performance

Comparing 11-01-perf_linter_no-unwanted-polyfillio_should_run_when_source_type_is_jsx (af261a0) with main (1b9f6fc)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (c45a080) during the generation of this report, so 1b9f6fc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 1, 2025
Copy link
Contributor

camc314 commented Nov 1, 2025

Merge activity

…sx (#15204)

I believe some of the rules under Next.js should only run when the source type variant is `jsx`. If that’s correct, I’ll gradually refine those rules across the next few PRs.
@graphite-app graphite-app bot force-pushed the 11-01-perf_linter_no-unwanted-polyfillio_should_run_when_source_type_is_jsx branch from af261a0 to 313e82e Compare November 1, 2025 12:11
@graphite-app graphite-app bot merged commit 313e82e into main Nov 1, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-01-perf_linter_no-unwanted-polyfillio_should_run_when_source_type_is_jsx branch November 1, 2025 12:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 1, 2025
@Boshen Boshen mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants