-
-
Notifications
You must be signed in to change notification settings - Fork 709
docs(linter): Add config docs for 4 more rules. #15196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-have-key-events rule.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds JSON schema support and documentation for configuration options across multiple linter rules by migrating from manual documentation in doc comments to structured schema-based configuration.
- Adds
JsonSchema,Deserialize, andSerializederives to configuration structs - Moves configuration documentation from rule doc comments to struct field doc comments
- Updates
declare_oxc_lint!macros to specify config types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/oxc_linter/src/rules/react/only_export_components.rs |
Adds schema support to OnlyExportComponentsOptionsJson, documents config fields, removes manual option docs |
crates/oxc_linter/src/rules/react/jsx_no_target_blank.rs |
Adds schema support to JsxNoTargetBlank and EnforceDynamicLinksEnum, documents config fields |
crates/oxc_linter/src/rules/jsx_a11y/mouse_events_have_key_events.rs |
Adds schema support to MouseEventsHaveKeyEventsConfig, documents config fields, fixes doc comment typos |
crates/oxc_linter/src/rules/eslint/prefer_destructuring.rs |
Adds schema support to PreferDestructuring and Config, documents config fields, removes manual option docs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #15196 will not alter performanceComparing Summary
Footnotes
|
Part of #14743.
Generated docs: