refactor(language_server): remove ServerLinterDiagnostics
#15169
+12
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the diagnostic storage mechanism in the ServerLinter by removing the intermediate ServerLinterDiagnostics wrapper struct and directly using Arc<ConcurrentHashMap> to store diagnostics.
- Removed the
ServerLinterDiagnosticsstruct and its associated methods - Simplified diagnostic access by directly interacting with the
ConcurrentHashMap - Removed the corresponding unit test that was testing the removed
ServerLinterDiagnosticsstruct
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
2 times, most recently
from
2c84365 to
1547df2
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sysix
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
from
1547df2 to
57f4002
Compare
graphite-app
bot
changed the base branch from
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
to
graphite-base/15169
Sysix
force-pushed
the
graphite-base/15169
branch
from
f211d1e to
4a2477b
Compare
Sysix
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
from
57f4002 to
039883c
Compare
Sysix
changed the base branch from
graphite-base/15169
to
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
graphite-app
bot
changed the base branch from
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
to
graphite-base/15169
graphite-app
bot
force-pushed
the
graphite-base/15169
branch
from
4a2477b to
10732e8
Compare
graphite-app
bot
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
from
039883c to
c8ef3d6
Compare
graphite-app
bot
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
from
c8ef3d6 to
ade11f5
Compare
camc314
approved these changes
Nov 4, 2025
Merge activity
|
> This PR refactors the diagnostic storage mechanism in the ServerLinter by removing the intermediate ServerLinterDiagnostics wrapper struct and directly using Arc<ConcurrentHashMap> to store diagnostics.
graphite-app
bot
force-pushed
the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
from
ade11f5 to
778b0b6
Compare
graphite-app
bot
deleted the
10-30-refactor_language_server_remove_serverlinterdiagnostics_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.