feat(napi/minify): expose treeshake options

[Copilot]

feat(napi/minify): expose treeshake options

Completed:

• Understand the problem: Need to expose TreeShakeOptions to JavaScript users
• Explore existing code structure and TreeShakeOptions in oxc_minifier
• Build the project to ensure clean state
• Add TreeShakeOptions struct with all fields
• Update CompressOptions to accept optional treeshake field
• Implement conversion from NAPI TreeShakeOptions to oxc_minifier::TreeShakeOptions
• Build and verify TypeScript definitions are generated correctly
• Add tests for treeshake options
• Run all tests successfully
• Format code with just fmt
• Address all review feedback:
  • Renamed TreeShakeOptionsNapi to TreeShakeOptions
  • Changed property_read_side_effects to accept boolean | 'always'
  • Changed @default from true to 'always' for property_read_side_effects
  • Reverted From implementation back to use reference (From<&TreeShakeOptions>)
  • Changed to TryFrom to properly handle validation errors
  • Added validation for propertyReadSideEffects string values
  • Fixed clippy lint for inline format args

Changes Made:

1. Added TreeShakeOptions struct with fields:
   • annotations: Whether to respect pure annotations (@PURE, #NO_SIDE_EFFECTS)
   • manual_pure_functions: List of function names to treat as pure
   • property_read_side_effects: Whether property reads have side effects (boolean | 'always', default: 'always')
   • unknown_global_side_effects: Whether accessing global variables has side effects
2. Updated CompressOptions to include optional treeshake field
3. Implemented TryFrom<&TreeShakeOptions> trait with proper error handling for invalid values
4. Added validation that rejects invalid string values for propertyReadSideEffects
5. Added tests covering treeshake functionality including error cases
6. Fixed all lint issues

All tests pass successfully!

Original prompt

Add bindings for treeshake option here:

oxc/napi/minify/src/options.rs

Line 90 in 3fbb307

treeshake: TreeShakeOptions::default(),

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Copilot]

Pull Request Overview

This PR adds support for configuring treeshake options through the NAPI minifier interface. The changes allow users to control dead code elimination behavior by configuring annotations, manual pure functions, property read side effects, and global variable access side effects.

• Defines a new TreeShakeOptions struct in Rust with conversion logic to the internal oxc_minifier types
• Adds a treeshake field to the CompressOptions struct
• Updates TypeScript type definitions with the new treeshake options interface
• Adds comprehensive test coverage for all treeshake configuration options

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
napi/minify/src/options.rs	Adds TreeShakeOptions struct, implements conversion to oxc_minifier types, and integrates treeshake options into CompressOptions
napi/minify/index.d.ts	Adds TypeScript interface definitions for TreeShakeOptions and updates CompressOptions interface
napi/minify/test/minify.test.ts	Adds test suite covering treeshake options including annotations, manual pure functions, and property read side effects

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sapphi-red]

@copilot change to try_from to fix the compile error

[Copilot]

@copilot change to try_from to fix the compile error

Done in 15b9d67. Changed from From to TryFrom to properly handle validation errors for invalid propertyReadSideEffects values. Also added a test to verify error handling.

[sapphi-red]

@copilot fix lint

[Copilot]

@copilot fix lint

Done in e235a5e. Fixed clippy lint by using inline format args ('{s}' instead of '{}' with s as a separate argument).

[Boshen]

Merge activity

• Oct 30, 8:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 30, 8:46 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 30, 8:51 AM UTC: Merged by the Graphite merge queue.