Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions crates/oxc_linter/src/tsgolint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,9 @@ struct TsGoLintDiagnosticPayload {
pub range: Range,
pub rule: String,
pub message: RuleMessage,
#[serde(default)]
pub fixes: Vec<Fix>,
#[serde(default)]
pub suggestions: Vec<Suggestion>,
pub file_path: PathBuf,
}
Expand Down Expand Up @@ -1030,4 +1032,75 @@ mod test {
])
);
}

#[test]
fn test_diagnostic_payload_deserialize_without_fixes_or_suggestions() {
use super::TsGoLintDiagnosticPayload;

// Test payload with both fixes and suggestions omitted
let json = r#"{
"range": {"pos": 0, "end": 10},
"rule": "no-unused-vars",
"message": {
"id": "msg_id",
"description": "Variable is unused",
"help": null
},
"file_path": "test.ts"
}"#;

let payload: TsGoLintDiagnosticPayload = serde_json::from_str(json).unwrap();
assert_eq!(payload.fixes.len(), 0);
assert_eq!(payload.suggestions.len(), 0);
assert_eq!(payload.rule, "no-unused-vars");

// Test payload with only fixes omitted
let json_with_suggestions = r#"{
"range": {"pos": 0, "end": 10},
"rule": "no-unused-vars",
"message": {
"id": "msg_id",
"description": "Variable is unused",
"help": null
},
"suggestions": [
{
"message": {
"id": "suggestion_id",
"description": "Remove unused variable",
"help": null
},
"fixes": []
}
],
"file_path": "test.ts"
}"#;

let payload: TsGoLintDiagnosticPayload =
serde_json::from_str(json_with_suggestions).unwrap();
assert_eq!(payload.fixes.len(), 0);
assert_eq!(payload.suggestions.len(), 1);

// Test payload with only suggestions omitted
let json_with_fixes = r#"{
"range": {"pos": 0, "end": 10},
"rule": "no-unused-vars",
"message": {
"id": "msg_id",
"description": "Variable is unused",
"help": null
},
"fixes": [
{
"text": "fixed",
"range": {"pos": 0, "end": 5}
}
],
"file_path": "test.ts"
}"#;

let payload: TsGoLintDiagnosticPayload = serde_json::from_str(json_with_fixes).unwrap();
assert_eq!(payload.fixes.len(), 1);
assert_eq!(payload.suggestions.len(), 0);
}
}
Loading