perf(formatter): optimize grouping logic for call arguments by Dunqing · Pull Request #15033 · oxc-project/oxc

Dunqing · 2025-10-28T08:49:22Z

No description provided.

Dunqing · 2025-10-28T08:49:37Z

perf(formatter): optimize grouping logic for call arguments #15033 👈 (View in Graphite)
fix(formatter): correct calculating layout for TSNonNullExpression in StaticMemberExpression #15065
fix(formatter): print parenthesis for sequence expression in ReturnStatement and ExpressionStatement #15062
fix(formatter): correct printing comments for TSAsExpression #15061
fix(formatter): correct checking of the short argument for CallArguments #15055
fix(formatter): print comments before fat arrow as-is for ArrowFunctionExpression #15050
fix(formatter): should hug parameter with TSMappedType type annotation #15049
fix(formatter): incorrect formatting of a function with this parameter #15031
refactor(formatter): simplify printing ClassElement with a semicolon #15030
fix(formatter): decorators and class method on the same line shouldn't be broken by a leading comment of the method #15029
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-28T08:54:35Z

CodSpeed Performance Report

Merging #15033 will not alter performance

_{Comparing 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments (d22291e) with 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression (673a357)}

Summary

✅ 33 untouched
⏩ 4 skipped¹

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Dunqing · 2025-10-29T16:36:03Z

Merge activity

Oct 29, 4:36 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 30, 1:02 AM UTC: Dunqing added this pull request to the Graphite merge queue.

crates/oxc_formatter/src/write/call_arguments.rs

Copilot

Pull Request Overview

This PR refactors the call argument grouping logic to optimize performance by avoiding redundant can_group_expression_argument calls when handling 2-argument cases. The key changes restructure the code to compute the grouping capability of the second argument only once and reuse it in both grouping strategy checks.

Special-case handling for exactly 2 arguments to avoid redundant computation
Extraction of common logic into should_group_last_argument_impl for code reuse
Refactoring of should_group_first_argument to accept individual arguments instead of a slice

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_formatter/src/write/call_arguments.rs

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - 6368793 oxfmt: V0.9.0 (#15091) (Boshen) - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

github-actions bot added A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 28, 2025

Dunqing changed the base branch from main to graphite-base/15033 October 29, 2025 16:33

Dunqing force-pushed the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch from 0b3df92 to d22291e Compare October 29, 2025 16:33

Dunqing changed the base branch from graphite-base/15033 to 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression October 29, 2025 16:33

Dunqing marked this pull request as ready for review October 29, 2025 16:35

Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

graphite-app bot force-pushed the 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression branch from 673a357 to 898ff76 Compare October 30, 2025 00:01

graphite-app bot force-pushed the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch from d22291e to dc56447 Compare October 30, 2025 00:02

graphite-app bot changed the base branch from 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression to graphite-base/15033 October 30, 2025 00:37

leaysgur reviewed Oct 30, 2025

View reviewed changes

crates/oxc_formatter/src/write/call_arguments.rs Show resolved Hide resolved

graphite-app bot force-pushed the graphite-base/15033 branch from 898ff76 to 99bd995 Compare October 30, 2025 00:43

graphite-app bot force-pushed the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch from dc56447 to 9b96389 Compare October 30, 2025 00:43

graphite-app bot changed the base branch from graphite-base/15033 to main October 30, 2025 00:43

graphite-app bot force-pushed the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch from 9b96389 to 468e3c1 Compare October 30, 2025 00:43

perf(formatter): optimize grouping logic for call arguments

811d4db

graphite-app bot force-pushed the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch from 468e3c1 to 811d4db Compare October 30, 2025 00:46

Rename to pass doctest

38ddb6d

Copilot AI review requested due to automatic review settings October 30, 2025 00:55

Copilot AI reviewed Oct 30, 2025

View reviewed changes

crates/oxc_formatter/src/write/call_arguments.rs Show resolved Hide resolved

leaysgur merged commit 467b3a1 into main Oct 30, 2025
26 checks passed

leaysgur deleted the 10-28-perf_formatter_optimize_grouping_logic_for_call_arguments branch October 30, 2025 01:02

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15088

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15091

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15096

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

perf(formatter): optimize grouping logic for call arguments#15033

perf(formatter): optimize grouping logic for call arguments#15033
leaysgur merged 2 commits intomainfrom
10-28-perf_formatter_optimize_grouping_logic_for_call_arguments

Dunqing commented Oct 28, 2025

Uh oh!

Dunqing commented Oct 28, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

Dunqing commented Oct 29, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

Dunqing commented Oct 28, 2025

Uh oh!

Dunqing commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15033 will not alter performance

Summary

Footnotes

Uh oh!

Dunqing commented Oct 29, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Oct 28, 2025 •

edited

Loading

codspeed-hq bot commented Oct 28, 2025 •

edited

Loading

Dunqing commented Oct 29, 2025 •

edited by graphite-app bot

Loading