Skip to content

fix(formatter): check whether a type alias is complex when its right hand side never break #14928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 27, 2025
Merged

fix(formatter): check whether a type alias is complex when its right hand side never break #14928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/oxc_formatter/src/utils/assignment_like.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,15 @@ impl<'a> AssignmentLike<'a, '_> {
}
}

if self.should_break_left_hand_side(left_may_break) {
return AssignmentLikeLayout::BreakLeftHandSide;
}

if self.should_break_after_operator(right_expression, f) {
return AssignmentLikeLayout::BreakAfterOperator;
}

if self.should_break_left_hand_side(left_may_break) {
if self.is_complex_type_alias() {
return AssignmentLikeLayout::BreakLeftHandSide;
}

Expand Down Expand Up @@ -522,10 +526,6 @@ impl<'a> AssignmentLike<'a, '_> {
return true;
}

if self.is_complex_type_alias() {
return true;
}

let Self::VariableDeclarator(declarator) = self else {
return false;
};
Expand Down
4 changes: 4 additions & 0 deletions crates/oxc_formatter/tests/fixtures/ts/assignments/type-alias.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export type _Repeat<A extends any, N extends number, L extends List = []> =
__Repeat<N, A, L> extends infer X
? Cast<X, List>
: never
13 changes: 13 additions & 0 deletions crates/oxc_formatter/tests/fixtures/ts/assignments/type-alias.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
source: crates/oxc_formatter/tests/fixtures/mod.rs
---
==================== Input ====================
export type _Repeat<A extends any, N extends number, L extends List = []> =
__Repeat<N, A, L> extends infer X
? Cast<X, List>
: never
==================== Output ====================
export type _Repeat<A extends any, N extends number, L extends List = []> =
__Repeat<N, A, L> extends infer X ? Cast<X, List> : never;

===================== End =====================
Loading