refactor(semantic): eliminate manual current_node_ix manipulation in try statements

[camc314]

fixes the TODO​ comments left in the code

[camc314]

• docs(semantic/cfg): add documentation for EdgeType #14859
• refactor(semantic): eliminate manual current_node_ix manipulation in try statements #14858 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors the control flow graph (CFG) construction for try-catch-finally statements by eliminating manual manipulation of current_node_ix. The key improvement is moving the creation of after_try_statement_block_ix inside conditional branches where it's actually needed, rather than creating it unconditionally upfront.

• Simplified CFG construction logic by removing direct current_node_ix assignments within catch and finally block handlers
• Consolidated block creation to only occur when needed based on the presence of catch/finally clauses
• Added explicit handling for try statements without catch or finally blocks

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_semantic/src/builder.rs	Refactored try statement CFG construction to conditionally create blocks and removed manual current_node_ix manipulation
crates/oxc_semantic/tests/integration/snapshots/labelled_try_break.snap	Updated CFG edge ordering in snapshot
crates/oxc_semantic/tests/integration/snapshots/labeled_block_break.snap	Updated CFG edge ordering in snapshot
crates/oxc_semantic/tests/integration/snapshots/function_in_finally.snap	Updated CFG edge ordering in snapshot
crates/oxc_semantic/tests/integration/snapshots/do_while_break.snap	Updated CFG edge ordering in snapshot

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Performance Report

Merging #14858 will not alter performance

_{Comparing c/10-21-refactor_semantic_eliminate_manual_current_node_ix_manipulation_in_try_statements (7d5b995) with main (f3b75c3)}

Summary

✅ 37 untouched

[camc314]

Merge activity

• Oct 21, 4:33 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 21, 4:35 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 21, 4:41 PM UTC: Merged by the Graphite merge queue.