feat(language_server): able to set off for run configuration#14746
feat(language_server): able to set off for run configuration#14746
off for run configuration#14746Conversation
f9ab58b to
f8258b1
Compare
74ad10b to
699c91c
Compare
f8258b1 to
9d81083
Compare
0db9067 to
ec7bcd3
Compare
|
Probably not something you have to fix now, but the properties should probably be reviewed and renamed to better match how they are used. Meaning if it's a property only for the linter, then something like |
ec7bcd3 to
1c363a6
Compare
|
@nrayburn-tech agree, Goal is to rename all options to have a |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for disabling the linter via a new Run::Off configuration option, allowing users to completely turn off linting in the language server.
Key changes:
- Introduced
Run::Offas a new variant in the linter configuration enum - Modified worker logic to conditionally initialize and refresh the linter based on the
Run::Offsetting - Added handling for dynamic enabling/disabling of the linter through configuration changes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_language_server/src/linter/options.rs | Added Run::Off enum variant to support disabling the linter |
| crates/oxc_language_server/src/worker.rs | Implemented conditional linter initialization, refresh logic, and watcher registration/unregistration based on Run::Off state |
| crates/oxc_language_server/src/linter/server_linter.rs | Updated linter run logic to handle Run::Off state and watch pattern registration when transitioning from off to on |
| crates/oxc_language_server/src/tester.rs | Added panic guard for disabled linter state in test helper |
| crates/oxc_language_server/README.md | Updated documentation to include "off" as a valid value for the run configuration option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1c363a6 to
181d253
Compare
|
Because there will be |

No description provided.