Skip to content

feat(linter): Add no-warning-comments rule #14734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 3 commits into from
Oct 17, 2025
Merged

feat(linter): Add no-warning-comments rule #14734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b35ce1
feat(linter): Add `no-warning-comments` rule
ivov Oct 17, 2025
4a2b96f
reorder
camc314 Oct 17, 2025
5553452
fix
camc314 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,11 @@ impl RuleRunner for crate::rules::eslint::no_void::NoVoid {
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::eslint::no_warning_comments::NoWarningComments {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnce;
}

impl RuleRunner for crate::rules::eslint::no_with::NoWith {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::WithStatement]));
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ pub(crate) mod eslint {
pub mod no_useless_rename;
pub mod no_var;
pub mod no_void;
pub mod no_warning_comments;
pub mod no_with;
pub mod operator_assignment;
pub mod prefer_destructuring;
Expand Down Expand Up @@ -792,6 +793,7 @@ oxc_macros::declare_all_lint_rules! {
eslint::no_useless_rename,
eslint::no_var,
eslint::no_void,
eslint::no_warning_comments,
eslint::no_with,
eslint::operator_assignment,
eslint::prefer_template,
Expand Down
Loading
Loading