Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug in dprint where it requires two formatting passes to reach a stable output state. The changes refactor the format function to run dprint twice consecutively and improve error handling by separating the formatting logic into a dedicated dprint helper function.
Key Changes:
- Run
dprinttwice to ensure stable formatting output - Extract
dprintexecution logic into a separate helper function that returnsResult<Vec<u8>, String> - Improve error handling by consolidating error reporting in the main
formatfunction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Running |
|
We found a different workaround in #14637, so this is no longer needed. |

dprintappears to be buggy, and in some cases requires 2 passes to reach a stable state. So run it twice.This problem discovered in: #14637 (comment)