Skip to content

Comments

feat(semantic): add symbol_id to ts function type binding idents#14673

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents
Oct 17, 2025
Merged

feat(semantic): add symbol_id to ts function type binding idents#14673
graphite-app[bot] merged 1 commit intomainfrom
c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 16, 2025 •
edited
Loading

fixes #14668

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Oct 16, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 16, 2025
This was referenced Oct 16, 2025
Merged
Merged
@camc314 camc314 marked this pull request as ready for review October 16, 2025 15:49
@camc314 camc314 requested a review from Dunqing as a code owner October 16, 2025 15:49
camc314
camc314 commented Oct 16, 2025
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14673 will not alter performance

Comparing c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents (3a835b4) with main (bec7a7d)

Summary

✅ 37 untouched

Dunqing
Dunqing requested changes Oct 16, 2025
View reviewed changes
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from df96c3f to 31b646b Compare October 16, 2025 15:55
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch from c125ad6 to 783a9f8 Compare October 16, 2025 15:55
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 31b646b to cddb43e Compare October 16, 2025 15:57
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from cddb43e to 937f768 Compare October 16, 2025 16:04
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch from 783a9f8 to 1662dc8 Compare October 16, 2025 16:04
@camc314 camc314 removed the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 16, 2025 •
edited
Loading

DO NOT MERGE: This needs more changes, we need scope_ids for more things

Fixed

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2025 •
edited
Loading

Merge activity

  • Oct 16, 4:08 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 16, 4:09 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 17, 4:30 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 17, 4:30 AM UTC: Dunqing added this pull request to the Graphite merge queue.
  • Oct 17, 4:36 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ to graphite-base/14673 October 16, 2025 16:09
@camc314 camc314 force-pushed the graphite-base/14673 branch from 1662dc8 to 5262d0d Compare October 16, 2025 16:10
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 937f768 to f4beec1 Compare October 16, 2025 16:10
@camc314 camc314 changed the base branch from graphite-base/14673 to c/10-16-feat_semantic_add_scope_to_tsconstructortype_ October 16, 2025 16:10
@camc314 camc314 mentioned this pull request Oct 16, 2025
Merged
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from f4beec1 to 7532224 Compare October 16, 2025 16:17
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Oct 16, 2025
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 7532224 to 2df531b Compare October 16, 2025 16:24
@graphite-app graphite-app bot changed the base branch from c/10-16-feat_semantic_add_scope_to_tsconstructortype_ to graphite-base/14673 October 17, 2025 01:59
@graphite-app graphite-app bot force-pushed the graphite-base/14673 branch from 5262d0d to bec7a7d Compare October 17, 2025 02:06
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 2df531b to 2fd9e45 Compare October 17, 2025 02:06
@graphite-app graphite-app bot changed the base branch from graphite-base/14673 to main October 17, 2025 02:07
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 2fd9e45 to 3a835b4 Compare October 17, 2025 02:07
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 3a835b4 to ae2003c Compare October 17, 2025 04:30
@graphite-app graphite-app bot merged commit ae2003c into main Oct 17, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch October 17, 2025 04:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@lilnasy lilnasy mentioned this pull request Oct 17, 2025
Closed
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
@Boshen Boshen mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript function type signature parameters have None symbol IDs in post-semantic AST

2 participants

@camc314 @Dunqing