perf(linter): only check for call expr once in unicorn/no-array-method-this

[camchenry]

Simple refactor to only do a single call expression check instead of two.

[camchenry]

• perf(linter): support getting as_member_expression_kind() variants #14642
• perf(linter): only check for call expr once in unicorn/no-array-method-this #14641 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR optimizes the no_array_method_this_argument linter rule by performing the call expression type check once at the entry point instead of redundantly checking in each helper function.

• Moved the CallExpression pattern match from helper functions to the run method
• Updated helper function signatures to accept &CallExpression directly instead of &AstNode
• Added CallExpression to the import list

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[camc314]

Merge activity

• Oct 15, 9:09 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 15, 9:09 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 15, 9:16 PM UTC: Merged by the Graphite merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #14641 will not alter performance

_{Comparing 10-15-perf_linter_only_check_for_call_expr_once_in_unicorn_no-array-method-this_ (58e17ae) with main (c8ea37d)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

Footnotes

1. No successful run was found on main (58e17ae) during the generation of this report, so c8ea37d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩