Skip to content

fix(napi/minify): s/passes/max_iterations to avoid confusion #14608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 15, 2025
Merged

fix(napi/minify): s/passes/max_iterations to avoid confusion #14608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napi/minify/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export interface CompressOptions {
*/
sequences?: boolean
/** Limit the maximum number of iterations for debugging purpose. */
passes?: number
maxIterations?: number
}

export interface CompressOptionsKeepNames {
Expand Down
4 changes: 2 additions & 2 deletions napi/minify/src/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub struct CompressOptions {
pub sequences: Option<bool>,

/// Limit the maximum number of iterations for debugging purpose.
pub passes: Option<u8>,
pub max_iterations: Option<u8>,
}

impl TryFrom<&CompressOptions> for oxc_minifier::CompressOptions {
Expand Down Expand Up @@ -81,7 +81,7 @@ impl TryFrom<&CompressOptions> for oxc_minifier::CompressOptions {
},
keep_names: o.keep_names.as_ref().map(Into::into).unwrap_or_default(),
treeshake: TreeShakeOptions::default(),
max_iterations: o.passes,
max_iterations: o.max_iterations,
})
}
}
Expand Down
Loading