Skip to content

test(napi/parser): fix and clarify exclude tests logic #14409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 7, 2025
Merged

test(napi/parser): fix and clarify exclude tests logic #14409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions napi/parser/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,25 @@
import { defineConfig } from 'vitest/config';
import { configDefaults, defineConfig } from 'vitest/config';

const { env, platform } = process;
const isEnabled = envValue => envValue === 'true' || envValue === '1';
const exclude = new Set<string>();
if (!isEnabled(env.RUN_LAZY_TESTS)) {
exclude.add('lazy-deserialization.test.ts');
if (!isEnabled(env.RUN_RAW_TESTS) && !isEnabled(env.RUN_RAW_RANGE_TESTS)) exclude.add('parse-raw.test.ts');
}
// TinyPool doesn't seem to work on Windows with Vitest

const runLazyTests = isEnabled(env.RUN_LAZY_TESTS);
let runRawTests = runLazyTests || isEnabled(env.RUN_RAW_TESTS) || isEnabled(env.RUN_RAW_RANGE_TESTS);

// Raw tests use `tinypool`, which doesn't seem to work on Windows with Vitest
// Ref: https://github.com/vitest-dev/vitest/issues/8201
if (platform === 'win32') {
exclude.add('parse-raw.test.ts');
}
if (platform === 'win32') runRawTests = false;

const exclude = [...configDefaults.exclude];
if (!runRawTests) exclude.push('parse-raw.test.ts');
if (!runLazyTests) exclude.push('lazy-deserialization.test.ts');

export default defineConfig({
test: {
diff: {
expand: false,
},
exclude: [...exclude],
exclude,
},
plugins: [
// Enable Codspeed plugin in CI only
Expand Down
Loading