refactor(parser): split check_method_definition by method kind#14364
Merged
Boshen merged 1 commit intooxc-project:mainfrom Oct 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the check_method_definition method by splitting it into three specialized functions based on method kind: accessors, constructors, and regular methods. This improves code organization by avoiding unnecessary checks and makes the validation logic more readable.
- Split
check_method_definitioninto kind-specific functions while preserving common validation logic - Updated call sites to use the appropriate specialized method based on context
- Reorganized abstract method validation to be specific to each method type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #14364 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
check_method_definitionby method kind intocheck_method_definition_accessor,check_method_definition_constructorandcheck_method_definition_methodand keep common logic incheck_method_definition. This avoids unnecessary checks and makes the logic easier to read.