fix(mangler): avoid reusing same mangled names in the outer class

[sapphi-red]

class Outer {
	#shared = 1;
	#getInner() {
		return class {
			#method() {
				return this.#shared;
			}
		};
	}
}

was transformed to

class Outer {
	#e = 1;
	#t() {
		return class {
			#e() {
				return this.#e;
			}
		};
	}
}

. This is wrong because this.#e points the #e method in the inner class rather than the #e in the outer class.
This PR fixes that by avoiding reusing the name used in the outer class.

[sapphi-red]

• fix(mangler): avoid reusing same mangled names in the outer class #14362 👈 (View in Graphite)
• fix(mangler): mangle private class members in subsequent classes correctly #14361
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14362 will not alter performance

_{Comparing 10-06-fix_mangler_avoid_reusing_same_mangled_names_in_the_outer_class (c257b41) with main (e605222)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

Footnotes

1. No successful run was found on 10-06-fix_mangler_mangle_private_class_members_in_subsequent_classes_correctly (fc519c8) during the generation of this report, so main (e605222) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Boshen]

Merge activity

• Oct 6, 9:26 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 6, 9:26 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 6, 9:36 AM UTC: Merged by the Graphite merge queue.