Skip to content

perf(linter/plugins): initialize lineStartOffsets as [0] #14302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 2, 2025
Merged

perf(linter/plugins): initialize lineStartOffsets as [0] #14302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/oxlint/src-js/plugins/source_code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ let sourceByteLen: number = 0;
let ast: Program | null = null;

// Lazily populated when `SOURCE_CODE.lines` is accessed.
// `lineStartOffsets` starts as `[0]`, and `resetSource` doesn't remove that initial element, so it's never empty.
const lines: string[] = [],
lineStartOffsets: number[] = [];
lineStartOffsets: number[] = [0];

// Lazily populated when `SOURCE_CODE.visitorKeys` is accessed.
let visitorKeys: { [key: string]: string[] } | null = null;
Expand Down Expand Up @@ -101,7 +102,7 @@ function initLines(): void {
* and uses match.index to get the correct line start indices.
*/

lineStartOffsets.push(0);
// Note: `lineStartOffsets` starts as `[0]`
let lastOffset = 0, offset, match;
while ((match = LINE_BREAK_PATTERN.exec(sourceText))) {
offset = match.index;
Expand All @@ -126,7 +127,7 @@ export function resetSource(): void {
sourceText = null;
ast = null;
lines.length = 0;
lineStartOffsets.length = 0;
lineStartOffsets.length = 1;
}

// `SourceCode` object.
Expand Down
Loading