Skip to content

Comments

feat(formatter/sort-imports): Implement options.sortSideEffects: bool#14293

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool
Oct 7, 2025
Merged

feat(formatter/sort-imports): Implement options.sortSideEffects: bool#14293
graphite-app[bot] merged 1 commit intomainfrom
10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Oct 2, 2025

Part of #14253

Implement sortSideEffects option, default false.

If true, side-effect imports are also sorted with other imports.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Oct 2, 2025
Copy link
Member Author

leaysgur commented Oct 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2025

CodSpeed Performance Report

Merging #14293 will not alter performance

Comparing 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool (5c8bd31) with 10-02-feat_formatter_sort-imports_add_options.order_asc_desc (593c416)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur force-pushed the 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool branch from f187f9d to 1d7b524 Compare October 2, 2025 06:24
@leaysgur leaysgur marked this pull request as ready for review October 2, 2025 06:30
@leaysgur leaysgur requested a review from Dunqing as a code owner October 2, 2025 06:30
@leaysgur leaysgur marked this pull request as draft October 2, 2025 10:32
@leaysgur leaysgur force-pushed the 10-02-feat_formatter_sort-imports_add_options.order_asc_desc branch from a3a8fc4 to fda4e93 Compare October 6, 2025 00:14
@leaysgur leaysgur force-pushed the 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool branch from 1d7b524 to a1b2d2b Compare October 6, 2025 00:14
@leaysgur leaysgur marked this pull request as ready for review October 6, 2025 09:37
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

…#14293)

Part of #14253

Implement `sortSideEffects` option, default `false`.

If `true`, side-effect imports are also sorted with other imports.
@graphite-app graphite-app bot force-pushed the 10-02-feat_formatter_sort-imports_add_options.order_asc_desc branch from fda4e93 to 593c416 Compare October 7, 2025 00:33
@graphite-app graphite-app bot force-pushed the 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool branch from a1b2d2b to 5c8bd31 Compare October 7, 2025 00:33
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Oct 7, 2025
Base automatically changed from 10-02-feat_formatter_sort-imports_add_options.order_asc_desc to main October 7, 2025 01:08
@graphite-app graphite-app bot merged commit 5c8bd31 into main Oct 7, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 10-02-feat_formatter_sort-imports_implement_options.sortsideeffects_bool branch October 7, 2025 01:09
@Boshen Boshen mentioned this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant