fix(linter): get cli args on JS side, to avoid runtime inconsistencies

[camc314]

fixes #14150

related: #14112, #14071

This seems to be the only reliable way to get arguments across different runtimes.

when running with deno, the args from std::env::args_os() look like:

[
    "/Users/cameron/.deno/bin/deno",
    "run",
    "--ext=js",
    "-A",
    "/Users/cameron/github/camc314/oxlint-repros/issue-14150/node_modules/.deno/oxlint@1.18.0/node_modules/oxlint/bin/oxlint",
    ".",
]

however process.argv looks like:

[
  "oxlint",
  "/Users/cameron/github/camc314/oxlint-repros/issue-14150/node_modules/.deno/oxlint@1.18.0/node_modules/oxlint/bin/oxlint",
  "."
]

so skipping the first two means that we end up with incorrect args that we're trying to parts.

There are (potentially) other solutions e.g. search for one of the args ending inoxlint, or other methods of trying to guess.

However, this feels like the most reliable solution.

[camc314]

• fix(linter): get cli args on JS side, to avoid runtime inconsistencies #14223 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes runtime inconsistencies when parsing CLI arguments by moving argument collection from Rust to the JavaScript side. The change addresses an issue where different JavaScript runtimes (like Deno) pass different argument structures to the Rust binary, causing incorrect argument parsing.

• Move CLI argument collection from Rust (std::env::args_os()) to JavaScript (process.argv.slice(2))
• Update the NAPI interface to accept arguments as the first parameter
• Convert JavaScript string arguments to OsString in Rust for compatibility with the existing command parser

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
apps/oxlint/src/run.rs	Modified NAPI function signature to accept CLI args and updated argument processing logic
apps/oxlint/src-js/cli.ts	Added argument collection from process.argv and passed to Rust function

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[overlookmotel]

however process.argv looks like:

[
  "oxlint",
  "/Users/cameron/github/camc314/oxlint-repros/issue14150/node_modules/.deno/oxlint@1.18.0/node_modules/oxlint/bin/oxlint",
  "."
]

That looks really weird. Isn't that what you'd expect to get if the command being run was oxlint oxlint .?

But sure, if it works on all platforms...

[camc314]

however process.argv looks like:

[
  "oxlint",
  "/Users/cameron/github/camc314/oxlint-repros/issue14150/node_modules/.deno/oxlint@1.18.0/node_modules/oxlint/bin/oxlint",
  "."
]

That looks really weird. Isn't that what you'd expect to get if the command being run was oxlint oxlint .?

But sure, if it works on all platforms...

Yeah this is what I observed to be working. i's probably something like deno doesn't spawn a new runtime for the cli arg, it re-uses the existing one or something

[camc314]

Merge activity

• Sep 29, 8:32 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 29, 8:32 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Sep 29, 8:40 AM UTC: Merged by the Graphite merge queue.

[camc314]

lets release with this change, and get some feedback from people using this in the real world