Skip to content

test(linter/plugins): convert all plugins in tests to TS #14200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overlookmotel merged 1 commit into from
Sep 28, 2025
Merged

test(linter/plugins): convert all plugins in tests to TS #14200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"rules": {
"basic-custom-plugin/no-debugger": "error"
}
Expand Down
6 changes: 5 additions & 1 deletion ...st/fixtures/basic_custom_plugin/plugin.js → ...st/fixtures/basic_custom_plugin/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'basic-custom-plugin',
},
Expand All @@ -17,3 +19,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/basic_custom_plugin_many_files/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"rules": {
"basic-custom-plugin/no-debugger": "error"
}
Expand Down
6 changes: 5 additions & 1 deletion .../basic_custom_plugin_many_files/plugin.js → .../basic_custom_plugin_many_files/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'basic-custom-plugin',
},
Expand All @@ -17,3 +19,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"rules": {
"basic-custom-plugin/no-debugger": "error",
"basic-custom-plugin/no-debugger-2": "error",
Expand Down
6 changes: 5 additions & 1 deletion ...ic_custom_plugin_multiple_rules/plugin.js → ...ic_custom_plugin_multiple_rules/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'basic-custom-plugin',
},
Expand Down Expand Up @@ -40,3 +42,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"rules": {
"basic-custom-plugin/no-debugger": "warn"
}
Expand Down
6 changes: 5 additions & 1 deletion ...res/custom_plugin_via_overrides/plugin.js → ...sic_custom_plugin_warn_severity/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'basic-custom-plugin',
},
Expand All @@ -17,3 +19,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/context_properties/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"context-plugin/log-context": "error"
Expand Down
12 changes: 8 additions & 4 deletions ...est/fixtures/context_properties/plugin.js → ...est/fixtures/context_properties/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { sep } from 'node:path';

import type { Plugin, Rule } from '../../../dist/index.js';

const SPAN = { start: 0, end: 0 };

const DIR_PATH_LEN = import.meta.dirname.length + 1;

const relativePath = sep === '/'
? path => path.slice(DIR_PATH_LEN)
: path => path.slice(DIR_PATH_LEN).replace(/\\/g, '/');
? (path: string) => path.slice(DIR_PATH_LEN)
: (path: string) => path.slice(DIR_PATH_LEN).replace(/\\/g, '/');

const rule = {
const rule: Rule = {
create(context) {
context.report({
message: `id: ${context.id}`,
Expand All @@ -35,11 +37,13 @@ const rule = {
},
};

export default {
const plugin: Plugin = {
meta: {
name: 'context-plugin',
},
rules: {
'log-context': rule,
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/createOnce/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"create-once-plugin/always-run": "error",
Expand Down
25 changes: 16 additions & 9 deletions ...oxlint/test/fixtures/createOnce/plugin.js → ...oxlint/test/fixtures/createOnce/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
import { sep } from 'node:path';

import type { Plugin, Rule } from '../../../dist/index.js';

const SPAN = { start: 0, end: 0 };

const DIR_PATH_LEN = import.meta.dirname.length + 1;

const relativePath = sep === '/'
? path => path.slice(DIR_PATH_LEN)
: path => path.slice(DIR_PATH_LEN).replace(/\\/g, '/');
? (path: string) => path.slice(DIR_PATH_LEN)
: (path: string) => path.slice(DIR_PATH_LEN).replace(/\\/g, '/');

let createOnceCallCount = 0;
const alwaysRunRule = {

const alwaysRunRule: Rule = {
createOnce(context) {
createOnceCallCount++;

// `this` should be the rule object
// oxlint-disable-next-line typescript-eslint/no-this-alias
const topLevelThis = this;

// Check that these APIs throw here
Expand Down Expand Up @@ -49,7 +54,7 @@ const alwaysRunRule = {
},
};

const skipRunRule = {
const skipRunRule: Rule = {
createOnce(context) {
return {
before() {
Expand All @@ -68,7 +73,7 @@ const skipRunRule = {
},
};

const beforeOnlyRule = {
const beforeOnlyRule: Rule = {
createOnce(context) {
return {
before() {
Expand All @@ -85,7 +90,7 @@ const beforeOnlyRule = {
},
};

const afterOnlyRule = {
const afterOnlyRule: Rule = {
createOnce(context) {
return {
Identifier(node) {
Expand All @@ -102,7 +107,7 @@ const afterOnlyRule = {
},
};

const noHooksRule = {
const noHooksRule: Rule = {
createOnce(context) {
return {
Identifier(node) {
Expand All @@ -115,7 +120,7 @@ const noHooksRule = {
},
};

export default {
const plugin: Plugin = {
meta: {
name: 'create-once-plugin',
},
Expand All @@ -128,7 +133,9 @@ export default {
},
};

function tryCatch(fn) {
export default plugin;

function tryCatch(fn: () => unknown) {
try {
fn();
} catch (err) {
Expand Down
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"test-plugin/no-var": "error",
Expand Down
6 changes: 5 additions & 1 deletion ...ustom_plugin_disable_directives/plugin.js → ...ustom_plugin_disable_directives/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'test-plugin',
},
Expand All @@ -19,3 +21,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_import_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"basic-custom-plugin/unknown-rule": "error"
Expand Down
4 changes: 2 additions & 2 deletions apps/oxlint/test/fixtures/custom_plugin_import_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
```
Failed to parse configuration file.

x Failed to load JS plugin: ./plugin.js
x Failed to load JS plugin: ./plugin.ts
| Error: whoops!
| at <root>/apps/oxlint/test/fixtures/custom_plugin_import_error/plugin.js:1:7
| at <root>/apps/oxlint/test/fixtures/custom_plugin_import_error/plugin.ts:1:7
```

# stderr
Expand Down
0 ...ures/custom_plugin_import_error/plugin.js → ...ures/custom_plugin_import_error/plugin.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"error-plugin/error": "error"
Expand Down
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
x Error running JS plugin.
| File path: <root>/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/files/index.js
| Error: Whoops!
| at after (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/plugin.js:10:19)
| at after (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/plugin.ts:12:19)

Found 0 warnings and 1 error.
Finished in Xms on 1 file using X threads.
Expand Down
6 changes: 5 additions & 1 deletion ...om_plugin_lint_after_hook_error/plugin.js → ...om_plugin_lint_after_hook_error/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'error-plugin',
},
Expand All @@ -14,3 +16,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"error-plugin/error": "error"
Expand Down
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
x Error running JS plugin.
| File path: <root>/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/files/index.js
| Error: Whoops!
| at before (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/plugin.js:10:19)
| at before (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/plugin.ts:12:19)

Found 0 warnings and 1 error.
Finished in Xms on 1 file using X threads.
Expand Down
6 changes: 5 additions & 1 deletion ...m_plugin_lint_before_hook_error/plugin.js → ...m_plugin_lint_before_hook_error/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'error-plugin',
},
Expand All @@ -14,3 +16,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"error-plugin/error": "error"
Expand Down
4 changes: 2 additions & 2 deletions apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
```
Failed to parse configuration file.

x Failed to load JS plugin: ./plugin.js
x Failed to load JS plugin: ./plugin.ts
| Error: Whoops!
| at Object.createOnce (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/plugin.js:8:15)
| at Object.createOnce (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/plugin.ts:10:15)
```

# stderr
Expand Down
6 changes: 5 additions & 1 deletion ...om_plugin_lint_createOnce_error/plugin.js → ...om_plugin_lint_createOnce_error/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'error-plugin',
},
Expand All @@ -10,3 +12,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_create_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"error-plugin/error": "error"
Expand Down
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_create_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
x Error running JS plugin.
| File path: <root>/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/files/index.js
| Error: Whoops!
| at Object.create (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/plugin.js:8:15)
| at Object.create (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/plugin.ts:10:15)

Found 0 warnings and 1 error.
Finished in Xms on 1 file using X threads.
Expand Down
6 changes: 5 additions & 1 deletion ...custom_plugin_lint_create_error/plugin.js → ...custom_plugin_lint_create_error/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
import type { Plugin } from '../../../dist/index.js';

const plugin: Plugin = {
meta: {
name: 'error-plugin',
},
Expand All @@ -10,3 +12,5 @@ export default {
},
},
};

export default plugin;
2 changes: 1 addition & 1 deletion apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jsPlugins": ["./plugin.js"],
"jsPlugins": ["./plugin.ts"],
"categories": { "correctness": "off" },
"rules": {
"error-plugin/error": "error"
Expand Down
4 changes: 2 additions & 2 deletions apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
x Error running JS plugin.
| File path: <root>/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/files/index.js
| Error: Whoops!
| at Object.fix (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/plugin.js:14:23)
| at Identifier (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/plugin.js:10:21)
| at Object.fix (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/plugin.ts:16:23)
| at Identifier (<root>/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/plugin.ts:12:21)

Found 0 warnings and 1 error.
Finished in Xms on 1 file using X threads.
Expand Down
Loading
Loading