fix(semantic): don't report abstract method with implementation twice#14193
Merged
Boshen merged 1 commit intooxc-project:mainfrom Sep 28, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a duplicate error reporting issue in the TypeScript semantic checker where abstract methods with implementation were being reported twice.
- Removes redundant error reporting for abstract methods with implementation
- Fixes double error messages by relying on existing match statement handling
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #14193 will not alter performanceComparing Summary
Footnotes |
Contributor
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link |
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
…oxc-project#14193) The match above the deleted line already reports depending on the kind of method.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
…oxc-project#14193) The match above the deleted line already reports depending on the kind of method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The match above the deleted line already reports depending on the kind of method.