fix(codegen): don't inject parenthesis in optional chaining within new expressions

[sapphi-red]

fixes #14127

[sapphi-red]

• fix(codegen): don't inject parenthesis in optional chaining within new expressions #14170 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14170 will not alter performance

_{Comparing 09-27-fix_codegen_don_t_inject_parenthesis_in_optional_chaining_within_new_expressions (aa927ab) with main (402e6c7)¹}

Summary

✅ 37 untouched

Footnotes

1. No successful run was found on main (06b16a9) during the generation of this report, so 402e6c7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull Request Overview

This PR fixes a codegen issue where parentheses were incorrectly being injected around optional chaining expressions within new expressions. The fix ensures that optional chaining operators (?.) are properly preserved without unwanted parentheses when used inside function or class constructors invoked with new.

• Updates context handling for Function and Class expressions to disable call parentheses injection
• Adds comprehensive test cases covering both function and class expressions with optional chaining

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_codegen/src/gen.rs	Modified context handling for Function and Class expressions to prevent unwanted parentheses injection
crates/oxc_codegen/tests/integration/js.rs	Added test cases verifying optional chaining works correctly within new expressions

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Boshen]

It seems like this is controlled by hasNonOptionalChainParent in esbuild. Our codegen should align with esbuild exactly.

[sapphi-red]

In esbuild, when printing the function expression inside the new expression, the forbidCall flag is not passed when printing the function block.

1. p.printExpr(e.Target, js_ast.LNew, forbidCall): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L2256
2. p.printFn(e.fn): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L2786
3. p.printBlock(fn.Body.Loc, fn.Body.Block): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L909C2-L909C42
4. p.printStmt(stmt, canOmitStatement): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L3780C3-L3780C38
5. p.printDeclStmt(s.IsExport, "let", s.Decls): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L4372C4-L4372C47
6. p.printDecls(keyword, decls, 0): https://github.com/evanw/esbuild/blob/d6b668f96fb00d6a6d035f058e38b6bd2507beb6/internal/js_printer/js_printer.go#L3708

So I think this change aligns the behavior with esbuild.

[Boshen]

Merge activity

• Sep 27, 9:48 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 27, 9:48 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Sep 27, 9:54 AM UTC: Merged by the Graphite merge queue.