Skip to content

fix(mangler): mangle non top-level exports variable #14169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 27, 2025
+27 −12
Merged

fix(mangler): mangle non top-level exports variable #14169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_mangler/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ impl<'t> Mangler<'t> {
}

fn is_special_name(name: &str) -> bool {
matches!(name, "exports" | "arguments")
matches!(name, "arguments")
}

#[derive(Debug)]
Expand Down
5 changes: 4 additions & 1 deletion crates/oxc_minifier/tests/mangler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ fn mangler() {
"function foo(a) { let { x } = y }",
"var x; function foo(a) { ({ x } = y) }",
"import { x } from 's'; export { x }",
"function _ (exports) { Object.defineProperty(exports, '__esModule', { value: true }) }",
"Object.defineProperty(exports, '__esModule', { value: true })",
"var exports = {}; Object.defineProperty(exports, '__esModule', { value: true })",
"function _(exports) { Object.defineProperty(exports, '__esModule', { value: true }) }",
"function _() { console.log(arguments) }",
"function foo(foo_a, foo_b, foo_c) {}; function bar(bar_a, bar_b, bar_c) {}", // foo_a and bar_a can be reused
"function _() { function foo() { var x; foo; } }", // x should not use the same name with foo
"function _() { var x; function foo() { var y; function bar() { x } } }", // y should not shadow x
Expand Down
18 changes: 15 additions & 3 deletions crates/oxc_minifier/tests/mangler/snapshots/mangler.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,21 @@ import { x } from 's'; export { x }
import { x } from "s";
export { x };

function _ (exports) { Object.defineProperty(exports, '__esModule', { value: true }) }
function _(exports) {
Object.defineProperty(exports, "__esModule", { value: true });
Object.defineProperty(exports, '__esModule', { value: true })
Object.defineProperty(exports, "__esModule", { value: true });

var exports = {}; Object.defineProperty(exports, '__esModule', { value: true })
var exports = {};
Object.defineProperty(exports, "__esModule", { value: true });

function _(exports) { Object.defineProperty(exports, '__esModule', { value: true }) }
function _(e) {
Object.defineProperty(e, "__esModule", { value: true });
}

function _() { console.log(arguments) }
function _() {
console.log(arguments);
}

function foo(foo_a, foo_b, foo_c) {}; function bar(bar_a, bar_b, bar_c) {}
Expand Down
14 changes: 7 additions & 7 deletions tasks/minsize/minsize.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ Original | minified | minified | gzip | gzip | Iterations | Fi

544.10 kB | 71.18 kB | 72.48 kB | 25.85 kB | 26.20 kB | 2 | lodash.js

555.77 kB | 270.78 kB | 270.13 kB | 88.19 kB | 90.80 kB | 2 | d3.js
555.77 kB | 267.47 kB | 270.13 kB | 88.05 kB | 90.80 kB | 2 | d3.js

1.01 MB | 439.56 kB | 458.89 kB | 122.14 kB | 126.71 kB | 2 | bundle.min.js
1.01 MB | 439.53 kB | 458.89 kB | 122.13 kB | 126.71 kB | 2 | bundle.min.js

1.25 MB | 645.63 kB | 646.76 kB | 159.54 kB | 163.73 kB | 2 | three.js
1.25 MB | 642.81 kB | 646.76 kB | 159.44 kB | 163.73 kB | 2 | three.js

2.14 MB | 713.53 kB | 724.14 kB | 160.99 kB | 181.07 kB | 2 | victory.js
2.14 MB | 712.15 kB | 724.14 kB | 160.92 kB | 181.07 kB | 2 | victory.js

3.20 MB | 1.00 MB | 1.01 MB | 323.10 kB | 331.56 kB | 3 | echarts.js
3.20 MB | 1.00 MB | 1.01 MB | 323.08 kB | 331.56 kB | 3 | echarts.js

6.69 MB | 2.22 MB | 2.31 MB | 459.26 kB | 488.28 kB | 4 | antd.js
6.69 MB | 2.22 MB | 2.31 MB | 459.15 kB | 488.28 kB | 4 | antd.js

10.95 MB | 3.34 MB | 3.49 MB | 855.24 kB | 915.50 kB | 4 | typescript.js
10.95 MB | 3.34 MB | 3.49 MB | 855.12 kB | 915.50 kB | 4 | typescript.js

Loading