fix(minifier): remove continue in for-in / for-of#14151
fix(minifier): remove continue in for-in / for-of#14151sapphi-red merged 3 commits intooxc-project:mainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with continue statement optimization by expanding the scope to include for-in and for-of loops in addition to regular for loops. The optimization transforms conditional continue statements into logical expressions for better minification.
- Expands continue statement optimization to handle for-in and for-of loops
- Adds comprehensive test coverage for all three types of for loops
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #14151 will not alter performanceComparing Summary
Footnotes
|
|
Thanks for tackling this. Quick note: Run |
|
We've recently merged changes to the Sorry! Oxc moves pretty fast and it's hard to avoid merge conflicts. |
6d76702 to
c8d275e
Compare
07a3f99 to
bb7e464
Compare
|
updated |
Signed-off-by: 翠 <green@sapphi.red>
sapphi-red
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
fix: #14063