Skip to content

fix(linter/plugins): defineRule accept visitor with no before / after hooks#14060

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks
Sep 23, 2025
Merged

fix(linter/plugins): defineRule accept visitor with no before / after hooks#14060
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 23, 2025

Fix defineRule. Previously it would throw an error if either before or after hooks was missing. Make it accept that without error.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Sep 23, 2025
Copy link
Member Author

overlookmotel commented Sep 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member Author

overlookmotel commented Sep 23, 2025

Merge activity

  • Sep 23, 10:27 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 10:27 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 23, 10:33 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Sep 23, 11:40 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 11:40 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 23, 11:45 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 09-23-test_linter_plugins_align_eslint_plugin_with_oxlint to graphite-base/14060 September 23, 2025 22:27
@graphite-app graphite-app bot changed the base branch from graphite-base/14060 to main September 23, 2025 22:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel overlookmotel force-pushed the 09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks branch from c661f6f to 01a122b Compare September 23, 2025 23:31
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
…after` hooks (#14060)

Fix `defineRule`. Previously it would throw an error if either `before` or `after` hooks was missing. Make it accept that without error.
@graphite-app graphite-app bot force-pushed the 09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks branch from 01a122b to fb3e7e3 Compare September 23, 2025 23:40
@graphite-app graphite-app bot merged commit fb3e7e3 into main Sep 23, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks branch September 23, 2025 23:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant