Skip to content

feat(npm/runtime): revert back to CJS #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Sep 22, 2025
Merged

feat(npm/runtime): revert back to CJS #13999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm/runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"engines": {
"node": "^20.19.0 || >=22.12.0"
},
"type": "module",
"type": "commonjs",
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the package type from module to commonjs alters how Node treats .js files and can break ESM consumers that relied on the package being ESM by default; this should be treated as a breaking change. Please bump the package with a semver-major release and note the change in the changelog.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Update the package README/CHANGELOG to document that the package defaults to CommonJS and provide clear import/require examples for both ESM and CJS consumers. This helps users adapt to the change and reduces integration friction.

Copilot uses AI. Check for mistakes.
"exports": {
"./helpers/OverloadYield": [
{
Expand Down
Loading