Fix missing dot in import.defer/import.source codegen#13974
Closed
Fix missing dot in import.defer/import.source codegen#13974
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] codegen: missing
Fix missing dot in import.defer/import.source codegen
Sep 21, 2025
. when printing import.defer
Member
|
Closed by #13975 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen was incorrectly printing import phase expressions without the dot separator. Consider:
Was being printed as:
This fix adds the missing dot (
.) betweenimportand the phase string in theImportExpressioncodegen implementation. The formatter was already handling this correctly, but the codegen was not consistent.The change is minimal and surgical - adding a single line to print the dot before the phase string, ensuring the output matches the expected JavaScript syntax for import phase expressions.
Fixes #13971.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.