Skip to content

Comments

docs(ast): document JSDocUnknownType#13973

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-21-docs_ast_document_jsdocunknowntype_
Sep 21, 2025
Merged

docs(ast): document JSDocUnknownType#13973
graphite-app[bot] merged 1 commit intomainfrom
09-21-docs_ast_document_jsdocunknowntype_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 21, 2025

I wasn't sure what this AST node is when implementing ESTree AST in oxlint plugins. Document it.

@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Sep 21, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 21, 2025 13:12
Copilot AI review requested due to automatic review settings September 21, 2025 13:12
@overlookmotel overlookmotel self-assigned this Sep 21, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Documents the JSDocUnknownType AST node to clarify its purpose for consumers implementing ESTree-compatible ASTs.

  • Adds a doc comment describing the JSDoc unknown type
  • No functional or behavioral code changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

overlookmotel commented Sep 21, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2025

CodSpeed Instrumentation Performance Report

Merging #13973 will not alter performance

Comparing 09-21-docs_ast_document_jsdocunknowntype_ (af8473a) with main (4543712)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (af8473a) during the generation of this report, so 4543712 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

I wasn't sure what this AST node is when implementing ESTree AST in oxlint plugins. Document it.
@graphite-app graphite-app bot force-pushed the 09-21-docs_ast_document_jsdocunknowntype_ branch from ab131dc to af8473a Compare September 21, 2025 15:02
@graphite-app graphite-app bot merged commit af8473a into main Sep 21, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-21-docs_ast_document_jsdocunknowntype_ branch September 21, 2025 15:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 21, 2025
This was referenced Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant