perf(parser): optimize parse_simple_arrow_function_expression#13965
Merged
Boshen merged 1 commit intooxc-project:mainfrom Sep 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the parse_simple_arrow_function_expression function by changing its parameter type from Expression to IdentifierReference and removing unnecessary context management code. The changes simplify the implementation and improve parser performance by approximately 1%.
- Refactored function signature to accept
IdentifierReferencedirectly instead ofExpression - Removed redundant context management around
self.ctx - Simplified parameter construction logic by eliminating pattern matching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_parser/src/js/expression.rs | Updated call site to pass identifier reference directly and reordered condition check |
| crates/oxc_parser/src/js/arrow.rs | Refactored function signature, removed context management, and simplified parameter construction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13965 will not alter performanceComparing Summary
|
camc314
approved these changes
Sep 21, 2025
Contributor
camc314
left a comment
There was a problem hiding this comment.
nice, codspeed shows 1% as well!
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function now accepts
IdentifierReferenceinstead ofExpressionto make its implementation simpler and avoid one match. Also all code aroundself.ctxis removed because it wasn't needed. This results in less code and a speedup in parser benchmarks of around 1% on my device.