Skip to content

fix(allocator): fix lint warning building WASM#13897

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-18-fix_allocator_fix_lint_warning_building_wasm
Sep 18, 2025
Merged

fix(allocator): fix lint warning building WASM#13897
graphite-app[bot] merged 1 commit intomainfrom
09-18-fix_allocator_fix_lint_warning_building_wasm

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 18, 2025

thread_count var is unused on 32-bit platforms, causing a lint warning when building playground.

@github-actions github-actions bot added the C-bug Category - Bug label Sep 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 09-18-fix_allocator_fix_lint_warning_building_wasm branch from 7505e3b to c39c7c5 Compare September 18, 2025 16:17
@overlookmotel overlookmotel marked this pull request as ready for review September 18, 2025 16:18
Copilot AI review requested due to automatic review settings September 18, 2025 16:18
@overlookmotel overlookmotel self-assigned this Sep 18, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a lint warning that occurs when building for WASM (32-bit platforms) where the thread_count variable is unused in the unsupported platform code path.

  • Adds a workaround to prevent unused variable lint warnings on 32-bit platforms

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

overlookmotel commented Sep 18, 2025

Merge activity

`thread_count` var is unused on 32-bit platforms, causing a lint warning when building playground.
@graphite-app graphite-app bot force-pushed the 09-18-fix_allocator_fix_lint_warning_building_wasm branch from c39c7c5 to 91c88e2 Compare September 18, 2025 16:23
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 18, 2025

CodSpeed Instrumentation Performance Report

Merging #13897 will not alter performance

Comparing 09-18-fix_allocator_fix_lint_warning_building_wasm (91c88e2) with main (d116504)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (91c88e2) during the generation of this report, so d116504 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit 91c88e2 into main Sep 18, 2025
25 of 26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
@graphite-app graphite-app bot deleted the 09-18-fix_allocator_fix_lint_warning_building_wasm branch September 18, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants