feat(napi/transform): add async transform function#13881
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 18, 2025
Merged
feat(napi/transform): add async transform function#13881graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-transformer
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an asynchronous transform function to the NAPI transform package, providing a Promise-based API alongside the existing synchronous transform function for better integration with async workflows.
- Added
transformAsyncfunction that returns a Promise using NAPI's AsyncTask - Implemented
TransformTaskstruct following the same pattern as the parser package - Added comprehensive tests to verify async behavior matches sync version
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
napi/transform/src/transformer.rs |
Core implementation of async transform with TransformTask struct |
napi/transform/test/transform.test.ts |
Test suite for async transform functionality |
napi/transform/index.js |
Export binding for transformAsync function |
napi/transform/transform.wasi.cjs |
WASI CommonJS export for transformAsync |
napi/transform/transform.wasi-browser.js |
WASI browser export for transformAsync |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
## Summary This PR adds an async transform function to the NAPI transform package, following the same pattern used in the parser package for consistency. Closes #10900 ## Changes - Added `transformAsync` function that returns a Promise - Implemented `TransformTask` struct with `napi::Task` trait - Reuses existing transform logic from the synchronous version - Added comprehensive tests to verify async behavior ## Test Plan Added tests in `test/transform.test.ts` that verify: - Async function works correctly - Produces identical results to sync version - Properly handles errors All existing tests continue to pass. 🤖 Generated with [Claude Code](https://claude.ai/code)
graphite-app
bot
force-pushed
the
feat/napi-transform-async
branch
from
e18b78c to
70c402b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an async transform function to the NAPI transform package, following the same pattern used in the parser package for consistency.
Closes #10900
Changes
transformAsyncfunction that returns a PromiseTransformTaskstruct withnapi::TasktraitTest Plan
Added tests in
test/transform.test.tsthat verify:All existing tests continue to pass.
🤖 Generated with Claude Code