Skip to content

feat(linter): add preserve-caught-error rule #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 4 commits into from
Sep 16, 2025
Merged

feat(linter): add preserve-caught-error rule #13748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcbd2a9
feat(linter): add `preserve-caught-error` rule
xiaokhkh Sep 13, 2025
9bbc9fe
Merge branch 'main' into 09-13-feat_linter_preserve_caught_error
xiaokhkh Sep 13, 2025
513309d
Merge branch 'main' into 09-13-feat_linter_preserve_caught_error
xiaokhkh Sep 14, 2025
abba09e
refactor: use visitor insteadof iterator. modify category to suspicious
xiaokhkh Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,11 @@ impl RuleRunner for crate::rules::eslint::prefer_template::PreferTemplate {
Some(&AstTypesBitset::from_types(&[AstType::BinaryExpression]));
}

impl RuleRunner for crate::rules::eslint::preserve_caught_error::PreserveCaughtError {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::TryStatement]));
}

impl RuleRunner for crate::rules::eslint::radix::Radix {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::CallExpression]));
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ pub(crate) mod eslint {
pub mod prefer_rest_params;
pub mod prefer_spread;
pub mod prefer_template;
pub mod preserve_caught_error;
pub mod radix;
pub mod require_await;
pub mod require_yield;
Expand Down Expand Up @@ -771,6 +772,7 @@ oxc_macros::declare_all_lint_rules! {
eslint::prefer_object_spread,
eslint::prefer_rest_params,
eslint::prefer_spread,
eslint::preserve_caught_error,
eslint::radix,
eslint::require_await,
eslint::require_yield,
Expand Down
Loading
Loading