chore(infra/vscode): switch esbuild to rolldown#13737
chore(infra/vscode): switch esbuild to rolldown#13737Boshen merged 1 commit intooxc-project:mainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-editor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces esbuild with rolldown as the bundler for the VS Code extension, implementing issue #13474. The change maintains the same build output while switching to the new bundler.
Key changes:
- Replace esbuild CLI commands with rolldown configuration files
- Update package.json dependencies to use rolldown instead of esbuild
- Create separate configurations for main build and test build processes
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| editors/vscode/rolldown.config.ts | Main rolldown configuration for building the extension |
| editors/vscode/rolldown.config.test.ts | Rolldown configuration for building test files |
| editors/vscode/package.json | Updated scripts and dependencies to use rolldown |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sysix
left a comment
Sysix
left a comment
There was a problem hiding this comment.
Thank you for the work ❤️
I have some NIT's. Please use version 1.0.0-beta.35, the bot does not know it better it this case ;)
I tried beta37 but locally, I get this error:
Error: Cannot find native binding. npm has a bug related to optional dependencies (npm/cli#4828). Please try
npm iagain after removing both package-lock.json and node_modules directory.
at file:///home/sysix/dev/oxc/node_modules/.pnpm/rolldown@1.0.0-beta.37/node_modules/rolldown/dist/shared/parse-ast-index-B5HcAOhq.mjs:10578:35
hikomoon
force-pushed
the
infra_vscode
branch
from
dc51e2d to
5797f84
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
got it, thanks for your review 🩵 |
Boshen
force-pushed
the
infra_vscode
branch
from
07d221b to
5b51e87
Compare
|
Thank you for the initiative ❤️ |
The tests are always passing, because we are not generating them: https://github.com/oxc-project/oxc/actions/runs/17858412366/job/50782751216?pr=13700 introduced in #13737
The tests are always passing, because we are not generating them: https://github.com/oxc-project/oxc/actions/runs/17858412366/job/50782751216?pr=13700 introduced in oxc-project/oxc#13737
4 participants
impl #13474
If there are any changes that are inappropriate, please let me know, I'd be happy to contribute a little bit from here on out☺️